Button not working in Android application

Question

I am new to Android and trying to implement a simple button, which should display a message in a Toast (eventually it's going to be used to create an account). But nothing happens when I press the button, no errors are displayed on the logcat either so I must be missing something obvious but I can't find it!!

AndroidManifest.xml

registration.xml

RegistrationActivity.java

 package com.example.laptop.whatsfordinner;


    import android.app.Activity;
    import java.util.ArrayList;
    import java.util.List;

    import org.apache.http.NameValuePair;
    import org.apache.http.message.BasicNameValuePair;
    import org.json.JSONException;
    import org.json.JSONObject;

    import android.app.Activity;
    import android.app.ProgressDialog;
    import android.content.Intent;
    import android.os.AsyncTask;
    import android.os.Bundle;
    import android.util.Log;
    import android.view.View;
    import android.widget.Button;
    import android.widget.EditText;
    import android.widget.Toast;



    public class RegistrationActivity extends Activity {


    // Progress Dialog
    private ProgressDialog pDialog;

    JSONParser jsonParser = new JSONParser();
    EditText inputName;
    EditText inputUsername;
    EditText inputEmail;
    EditText inputPassword;

    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.registration);

        // Create button
       Button btnRegister1 = (Button) findViewById(R.id.btnRegister);

        // button click event
        btnRegister1.setOnClickListener(new View.OnClickListener() {

            @Override
            public void onClick(View view) {
                // creating new account in background thread
                Toast.makeText(RegistrationActivity.this, "Example action.",      Toast.LENGTH_SHORT).show();

            }
        });
    }

Registration.java

package com.example.laptop.whatsfordinner;

import android.app.Activity;
import android.support.v7.app.AppCompatActivity;
import android.support.v7.app.ActionBar;
import android.support.v4.app.Fragment;
import android.support.v4.app.FragmentManager;
import android.os.Bundle;
import android.view.LayoutInflater;
import android.view.Menu;
import android.view.MenuItem;
import android.view.View;
import android.view.ViewGroup;
import android.support.v4.widget.DrawerLayout;

public class Registration extends Fragment {
    /**
     * The fragment argument representing the section number for this
     * fragment.
     */
    private static final String ARG_SECTION_NUMBER = "section_number";

    /**
     * Returns a new instance of this fragment for the given section
     * number.
     */
    public static Registration newInstance(int sectionNumber) {
        Registration fragment = new Registration();
        Bundle args = new Bundle();
        args.putInt(ARG_SECTION_NUMBER, sectionNumber);
        fragment.setArguments(args);
        return fragment;
    }

    public Registration() {
    }

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {
        View rootView = inflater.inflate(R.layout.registration, container, false);
        return rootView;
    }

    @Override
    public void onAttach(Activity activity) {
        super.onAttach(activity);
        ((MainPage) activity).onSectionAttached(
                getArguments().getInt(ARG_SECTION_NUMBER));
    }

    @Override
    public void onDetach() {
        super.onDetach();
    }
}

What am I doing wrong?

ʍѳђઽ૯ท · Accepted Answer

You are inflating a Layout in a Fragment and in an Activity.

If you want to handle that Button in your Fragment, do this:

@Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
        View rootView = inflater.inflate(R.layout.activity_main, container, false);

        Button regButton1 = (Button) rootView.findViewById(R.id.btnRegister);

        regButton1.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                Toast.makeText(getActivity(), "Example action", Toast.LENGTH_SHORT).show();
            }
        });

        return rootView;
    }

The code in your Activity looks good but, you were inflating the same Layout for both.

See:

setContentView(R.layout.registration);

And:

View rootView = inflater.inflate(R.layout.registration, container, false);

Also, Press CTRL + Alt + O to remove the unused import, finally, it should be like this(Your Fragment's imports):

import android.app.Activity;
import android.os.Bundle;
import android.support.v4.app.Fragment;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.Button;
import android.widget.Toast;

And like i guessed, the problem is because you were inflating a Layout in a Fragment and in an Activity.and i've tried that and it worked with that Activity.

(nice question by the way).

Solution: Set your own Layout for Fragment and your Activity but not the same Layout for both.

Then, you're ready to go.

Button not working in Android application

Answers (1)

Related Questions