CODEWITHSUNDEEP
c#listcompare.net-4.5
deadpool_Y7
deadpool_Y7

Reputation: 139

Most efficient way to compare two lists and delete the same

I want to compare two lists and get the valid words into a new list.

var words = new List<string>();
var badWords = new List<string>();

//this is just an example list. actual list does contain 700 records
words.Add("Apple");
words.Add("Moron");
words.Add("Seafood");
words.Add("Cars");
words.Add("Chicken");
words.Add("Twat");
words.Add("Watch");
words.Add("Android");
words.Add("c-sharp");
words.Add("Fool");

badWords.Add("Idiot");
badWords.Add("Retarded");
badWords.Add("Twat");
badWords.Add("Fool");
badWords.Add("Moron");

I am looking for most efficient way to compare the lists and put all the 'good' words into a new list. The finalList shouldn't contain "Moron", "Twat" and "Fool".

var finalList = new List<string>();

Or is it unnecessary to create a new List? I am happy to hear your ideas!

Thank you in advance

Upvotes: 4

Views: 3740

Answers (5)

fubo
fubo

Reputation: 45947

If your don't want to create a new List you can remove the bad words from your existing List with RemoveAll()

words.RemoveAll(badWords.Contains);

Upvotes: 0

Konstantin Zadiran
Konstantin Zadiran

Reputation: 1541

Use EnumerableExcept function storing in System.Linq namespace

finalList = words.Except(badWords).ToList();

Most efficient way to save your time and also the fastest way to do it, because Except implementation uses Set, which is fast

Upvotes: 10

Gabe
Gabe

Reputation: 670

https://msdn.microsoft.com/library/bb908822(v=vs.90).aspx

var words = new List<string>();
var badWords = new List<string>();

//this is just an example list. actual list does contain 700 records
words.Add("Apple");
words.Add("Moron");
words.Add("Seafood");
words.Add("Cars");
words.Add("Chicken");
words.Add("Twat");
words.Add("Watch");
words.Add("Android");
words.Add("c-sharp");
words.Add("Fool");

badWords.Add("Idiot");
badWords.Add("Retarded");
badWords.Add("Twat");
badWords.Add("Fool");
badWords.Add("Moron");

var result = words.Except(badWords).ToList();

Edit: Got in late.

Upvotes: 2

Viru
Viru

Reputation: 2246

you can use contains method

words.Where(g=>!badWords.Contains(g)).ToList()

Upvotes: 1

Tim Schmelter
Tim Schmelter

Reputation: 460058

Use Enumerable.Except:

List<string> cleanList = words.Except(badWords).ToList();

This is efficient because Except uses a set based approach.

An even more efficient approach is to avoid that "bad" words are added to the first list at all. For example by using a HashSet<string> with a case-insensitive comparer:

var badWords = new HashSet<string>(StringComparer.InvariantCultureIgnoreCase){ "Idiot", "Retarded", "Twat", "Fool", "Moron" };

string word = "idiot";
if (!badWords.Contains(word))
    words.Add(word);

Upvotes: 7

Related Questions