CODEWITHSUNDEEP
pythondjango
chazefate
chazefate

Reputation: 822

Django password mismatching get attribute

I have come to this problem in registration.

I have my registration in forms.py:

class UserForm(forms.ModelForm):
    password = forms.CharField(widget=forms.PasswordInput())
    confirm_password = forms.CharField(widget=forms.PasswordInput())

    class Meta:
        model = User
        fields = ('username', 'email')

    def clean(self):
       # Check that the two password entries match
       password = self.cleaned_data.get("password")
       conf_password = self.cleaned_data.get("confirm_password")
       if conf_password and password and conf_password != password:
           raise forms.ValidationError("Passwords don't match")
       return password

and when I try to register from my local host then this happens:

AttributeError at /signup/
'str' object has no attribute 'get'
Request Method: POST
Request URL:    http://127.0.0.1:8000/signup/
Django Version: 1.9.1
Exception Type: AttributeError
Exception Value:    
'str' object has no attribute 'get'
Exception Location: C:\Users\Hai\AppData\Local\Programs\Python\Python35-32\lib\site-packages\django\forms\models.py in _get_validation_exclusions, line 337
Python Executable:  C:\Users\Hai\AppData\Local\Programs\Python\Python35-32\python.exe
Python Version: 3.5.0
Python Path:    
['C:\\Users\\Hai\\OneDrive\\WebSoftware\\p3\\wsd_game',
 'C:\\Users\\Hai\\AppData\\Local\\Programs\\Python\\Python35-32\\python35.zip',
 'C:\\Users\\Hai\\AppData\\Local\\Programs\\Python\\Python35-32\\DLLs',
 'C:\\Users\\Hai\\AppData\\Local\\Programs\\Python\\Python35-32\\lib',
 'C:\\Users\\Hai\\AppData\\Local\\Programs\\Python\\Python35-32',
 'C:\\Users\\Hai\\AppData\\Local\\Programs\\Python\\Python35-32\\lib\\site-packages']
Server time:    Sat, 20 Feb 2016 20:09:17 +0200

This problem goes away if I comment def clean(self) but I need the passwords to match each others.

Everything else goes as planned except for this registration form. When I have completed the form and pressed register then comes the 'get' attribute error.

View

def register(request):
# Like before, get the request's context.
    context = RequestContext(request)

    # A boolean value for telling the template whether the registration was successful.
    # Set to False initially. Code changes value to True when registration succeeds.
    registered = False

    # If it's a HTTP POST, we're interested in processing form data.
    if request.method == 'POST':
        # Attempt to grab information from the raw form information.
        # Note that we make use of both UserForm and UserProfileForm.
        user_form = UserForm(data=request.POST)
        profile_form = UserProfileForm(data=request.POST)

        # If the two forms are valid...
        if user_form.is_valid() and profile_form.is_valid():
            # Save the user's form data to the database.
            user = user_form.save()

            # Now we hash the password with the set_password method.
            # Once hashed, we can update the user object.
            user.set_password(user.password)
            user.save()

            # Now sort out the UserProfile instance.
            # Since we need to set the user attribute ourselves, we set commit=False.
            # This delays saving the model until we're ready to avoid integrity problems.
            profile = profile_form.save(commit=False)
            profile.user = user

            # Did the user provide a profile picture?
            # If so, we need to get it from the input form and put it in the UserProfile model.
            if 'picture' in request.FILES:
                profile.picture = request.FILES['picture']

            # Now we save the UserProfile model instance.
            profile.save()

            # Update our variable to tell the template registration was successful.
            registered = True

            # Invalid form or forms - mistakes or something else?
            # Print problems to the terminal.
        # They'll also be shown to the user.
        else:
            print (user_form.errors, profile_form.errors)

    # Not a HTTP POST, so we render our form using two ModelForm instances.
    # These forms will be blank, ready for user input.
    else:
        user_form = UserForm()
        profile_form = UserProfileForm()

    # Render the template depending on the context.
    return render_to_response(
            'registration/sign_up.html',
            {'user_form': user_form, 'profile_form': profile_form, 'registered': registered},
            context)

models:

class UserProfile(models.Model):
    # This line is required. Links UserProfile to a User model instance.
    user = models.OneToOneField(User)

    # The additional attributes we wish to include.
    website = models.URLField(blank=True)
    picture = models.ImageField(upload_to='profile_images', blank=True)
    CHOICES = (('pl', 'Player'),('dv', 'Developer'),)
    user_type = models.CharField(max_length=2,choices=CHOICES,default='pl')


    # Override the __unicode__() method to return out something meaningful!
    def __unicode__(self):
        return self.user.username

Upvotes: 1

Views: 1082

Answers (1)

Shahin
Shahin

Reputation: 1475

At the end of your clean function you are returning the password itself and model view can't access it with get (since it's a string). Just put return self.cleaned_data instead of return password and everything should work fine.

Upvotes: 2

Related Questions