Shivanand Mitakari
Shivanand Mitakari

Reputation: 515

How can I use decorators in a React Redux application?

I’m creating simple application using React Redux. I want to use decorator to inject some methods in my component.. I saw similar code in other projects:

import React, { Component } from 'react';
import { connect } from 'react-redux';


@creatable
export default class BookDetails extends Component {

  render() {
    console.log(this.props);
    if (!this.props.Activebook) {
      return <div> please select book</div>
    }
    return (
        <div>{this.props.Activebook.title}</div>
    );
  }
}


function creatable() {
  return Create => {
    @connect(state=>({Activebook : state.ActiveBook}))
   class MyDecorator extends Component {
     render() {
       console.log('>>>>>>>>>>>>>');
    console.log(this.props);
       console.log('>>>>>>>>>>>>>');
       return (
         <div>
           <Create
              {...this.props}
           />
         </div>
       )
     }

   }
    return MyDecorator;
  }
}

Unfortunately the above code is not working. Why?

Upvotes: 10

Views: 4757

Answers (2)

Dan Abramov
Dan Abramov

Reputation: 268225

Please note that we do not recommend using decorators for connecting components. You won’t find them anywhere in the official docs or examples.

Just because some community examples use them doesn’t mean it’s a good idea: the spec is still changing, the tooling support is flaky, and frankly, you don’t need decorators for connect() because they desugar to simple function calls.

For example, rather than

@connect(mapStateToProps)
class MyComponent extends Component {}

you should write

class MyComponent extends Component {}
MyComponent = connect(mapStateToProps)(MyComponent)

This way you won’t have to worry about them breaking until the proposal is part of the language.

I recommend you to stick to the conventions we use in the official Redux examples and be very cautious about adopting experimental syntax extensions.

Upvotes: 13

rossipedia
rossipedia

Reputation: 59367

Babel 6 doesn't support decorators with the es2015 preset, nor with the stage-0 preset. You'll have to add the babel-plugin-transform-decorators-legacy plugin to enable decorators:

$ npm install --save-dev babel-plugin-transform-decorators-legacy

And add to your plugins in .babelrc:

{
  "plugins": [
    "transform-decorators-legacy",
    ...
  ]
}

This is the easiest way I know of to get decorator support. They're not included in babel by default as they haven't actually been standardized yet.

Upvotes: 4

Related Questions