CODEWITHSUNDEEP
pythondjangovalidationformset
Carlos Herrera
Carlos Herrera

Reputation: 105

Formset.is_valid() False, why?

I'm trying to validate a form set, it shows in the template perfectly but when I try to save it, its validation returns False.

I tried to put some errors callbacks and the error in print(formset.non_form_errors) say the following: 

<bound method PhysicianSpecialtiesFormFormSet.non_form_errors of <django.forms.formsets.PhysicianSpecialtiesFormFormSet object at 0x7fd70af38a10>>

I don't know what to do to have a correct input in the form; the form is a dropdown list, and it's impossible to get wrong. 

def UpdatePhysician(request,id):

physician = get_object_or_404(Physician, id=id)
employee = get_object_or_404(Employee, id=physician.employee.id)
person = get_object_or_404(Person, id=employee.person.id)
try:
    address = get_object_or_404(Address, id=return_id(str(person.addresses.values('id'))))
except:
    address = None
try:
    email = get_object_or_404(Email, id=return_id(str(person.emails.values('id'))))
except:
    email = None
try:
    phone = get_object_or_404(PhoneNumber, id=return_id(str(person.phone_numbers.values('id'))))
except:
    phone = None
try:
    academic_degree = get_object_or_404(AcademicDegree, id=return_id(str(employee.academic_degrees.values('id'))))
    university = get_object_or_404(University, id=return_id(str(employee.academic_degrees.values('university'))))
except:
    academic_degree = None
    university = None

physician_specialties = get_list_or_404(PhysicianSpecialties, employee_academic_degree__employee__pk=physician.employee.id)
for item in physician_specialties:
    print(unicode(item.specialty))
specialties = Specialty.objects.all()
specialty = PhysicianSpecialties.objects.filter(employee_academic_degree__employee__physician__pk=id)


SpecialtyFormset = modelformset_factory(PhysicianSpecialties, fields=('specialty',),max_num=1, labels=None, )
formset = SpecialtyFormset(queryset=PhysicianSpecialties.objects.filter(employee_academic_degree__employee__pk=physician.employee.id))
person_form = PersonForm(request.POST or None, instance=person)
employee_form = EmployeeForm(request.POST or None, instance=employee)
physician_form = PhysicianForm(request.POST or None, instance=physician)
email_form = EmailForm(request.POST or None, instance=email)
address_form = AddressForm(request.POST or None, instance=address)
phone_form = PhoneForm(request.POST or None, instance=phone)
academic_degree_form = AcademicDegreeForm(request.POST or None, instance= academic_degree)
university_form = UniversityForm(request.POST or None, instance=university)



if request.method == "POST":

    if (person_form.is_valid() and employee_form.is_valid() and physician_form.is_valid() and email_form.is_valid() and
            address_form.is_valid() and phone_form.is_valid and physician_form.is_valid() and university_form.is_valid and
            academic_degree_form.is_valid() and formset.is_valid()):
        person_form.save()
        physician_form.save()
        new_address = address_form.save()
        new_email = email_form.save()
        new_phone = phone_form.save()
        # academic_degree_form.save()
        # university_form.save()
        formset.save()

        if address == None:
            PersonAddress.objects.create(person=person, address=new_address)

        if email == None:
            PersonEmail.object.create(person=person, email=new_email)

        if phone == None:
            PersonPhoneNumber.objects.create(person=person, hone_number=new_phone)

        return HttpResponse('yesh')
    else:
        print(formset.is_valid())
        print(formset.non_form_errors)
        print('nope')
        return HttpResponse('nope')

Upvotes: 4

Views: 3673

Answers (1)

Alasdair
Alasdair

Reputation: 308909

You haven't passed data to your formset. Without post data, your formset is unbound and will always be invalid. 

formset = SpecialtyFormset(request.POST or None,  queryset=PhysicianSpecialties.objects.filter(employee_academic_degree__employee__pk=physician.employee.id))

Another problem is that you are trying to display the errors incorrectly. formset.non_form_errors is a method, you have to call it.

print(formset.non_form_errors())

There may also be errors attached to the forms in the formset, you can see these by printing formset.errors.

print(formset.errors)

Upvotes: 5

Related Questions