CODEWITHSUNDEEP
c#linq-to-sql
Owlface
Owlface

Reputation: 13

Linq-To-SQL .ToList() operator

Is there a better way of doing this?

I have a Linq-To-SQL query that I need to return objects defined by abstract interfaces (e.g. IList<IUser>) rather than concrete objects (e.g. List<User>).

// get users from data context

        List<User> users;

        using (AbleridgeDataContext context = new AbleridgeDataContext())
        {

            users = (from u in context.Users select u).ToList();
        }

        // reassign concrete users to abstract interfaces

        IList<IUser> genericUsers = new List<IUser>();

        foreach (var user in users)
        {
            IUser genericUser = user;
            genericUsers.Add(genericUser);
        }

        return genericUsers;

Upvotes: 1

Views: 5987

Answers (5)

Alka
Alka

Reputation: 29

From the MSDN website:

public static List<TSource> ToList<TSource>(this IEnumerable<TSource> source)

Have you tried context.Users.ToList<IUser>()?

Also regarding the context, the ToList method will force the query to be evaluated so the result will be available after the context is disposed.

Upvotes: 0

Mikael Svenson
Mikael Svenson

Reputation: 39695

Declare users as IList and cast User to IUser with linq.

ToList returns an IEnumerable, which is implemented my IList and List, so it really doesn't matter which one you declare users as.

    IList<IUser> users;
    using (AbleridgeDataContext context = new AbleridgeDataContext())
    {
        users = (from u in context.Users select u).Cast<IUser>().ToList();
    }

Upvotes: 0

Juliet
Juliet

Reputation: 81536

return context.Users.Cast<IUser>().ToList();

Alternatively:

List<IUser> users = new List<IUser>(context.Users);

Upvotes: 2

joshperry
joshperry

Reputation: 42317

You could cast to IUser in the projection part of the query:

    List<User> users;
    using (AbleridgeDataContext context = new AbleridgeDataContext())
    {
        return from u in context.Users select (IUser)u;
    }

The one change this would require is to make your function return IEnumerable<IUser> which would be better anyway because the query won't be executed until the caller begins enumerating.

Though you could also just use ToList still if you're not interested in changing that.

Update Actually you probably will want to use ToList here because the using statement is disposing of your data context as soon as the function returns so a lazy query would fail.

Upvotes: 1

Greg Bogumil
Greg Bogumil

Reputation: 1923

Try this instead. It will return IEnumerable<IUser>

using (AbleridgeDataContext context = new AbleridgeDataContext())
{
    return context.Users.Select((IUser)u);
}

If you really want IList then set your function return type to IList<IUser> and add a .ToList() to the end of the return statement.

Or

return context.Users.OfType<IUser>();

Upvotes: 0

Related Questions