CODEWITHSUNDEEP
javascriptejs
J.C.
J.C.

Reputation: 61

ejs.renderFile in js file got a error

I am new to Node.js. The following code I run in a js file got a error :"'An error occurred: renderFile(siginin.ejs)". Cannot figure why?

ejs.renderFile('./views/signin.ejs',function(err, result) {
   if (!err) {
            res.end(result);
   }
   else {
            res.end('An error occurred: renderFile(siginin.ejs)');
            console.log(err);
   }

});

errors:

cb is not a function

TypeError: cb is not a function
at Object.exports.renderFile (C:\Users\MyPC\workspace\Nodejs_Login\node_modules\ejs\lib\ejs.js:353:12)
at signin (C:\Users\MyPC\workspace\Nodejs_Login\routes\home.js:10:6)
at Layer.handle [as handle_request] (C:\Users\MyPC\workspace\Nodejs_Login\node_modules\express\lib\router\layer.js:95:5)
at next (C:\Users\MyPC\workspace\Nodejs_Login\node_modules\express\lib\router\route.js:131:13)
at Route.dispatch (C:\Users\MyPC\workspace\Nodejs_Login\node_modules\express\lib\router\route.js:112:3)
at Layer.handle [as handle_request] (C:\Users\MyPC\workspace\Nodejs_Login\node_modules\express\lib\router\layer.js:95:5)
at C:\Users\MyPC\workspace\Nodejs_Login\node_modules\express\lib\router\index.js:277:22
at Function.process_params (C:\Users\MyPC\workspace\Nodejs_Login\node_modules\express\lib\router\index.js:330:12)
at next (C:\Users\MyPC\workspace\Nodejs_Login\node_modules\express\lib\router\index.js:271:10)
at C:\Users\MyPC\workspace\Nodejs_Login\node_modules\express\lib\router\index.js:618:15

i visit this link in browser and got above error: http://localhost:3000/signin

app.js:

var home = require('./routes/home'); //add label
app.get('/signin', home.signin);

This is the file of home.js:

home.js 

/**
* New node file
*/
var ejs = require("ejs");
var mysql = require('./mysql');

function signin(req,res) {

ejs.renderFile('./views/signin.ejs',function(err, result) {
   // render on success
   if (!err) {
            res.end(result);
   }
   // render or error
   else {
            res.end('An error occurred: renderFile(siginin.ejs)');
            console.log(err);
   }
   });

  }


function afterSignIn(req,res)
{
// check user already exists
var getUser="select * from users where username='"+req.param("inputUsername")+"' and password='" + req.param("inputPassword") +"'";
console.log("Query is:"+getUser);

mysql.fetchData(function(err,results){
    if(err){
        throw err;
    }
    else 
    {
        if(results.length > 0){
            console.log("valid Login");
            ejs.renderFile('./views/successLogin.ejs', { data: results } , function(err, result) {
                // render on success
                if (!err) {
                    res.end(result);
                }
                // render or error
                else {
                    res.end('An error occurred: renderFile(successLogin.ejs)');
                    console.log(err);
                }
            });
        }
        else {    

            console.log("Invalid Login");
            ejs.renderFile('./views/failLogin.ejs',function(err, result) {
                // render on success
                if (!err) {
                    res.end(result);
                }
                // render or error
                else {
                    res.end('An error occurred: renderFile(failLogin.ejs).');
                    console.log(err);
                }
            });
        }
    }  
},getUser);
}

Upvotes: 2

Views: 3631

Answers (1)

peteb
peteb

Reputation: 19418

You can set EJS as a View Engine in Express and use res.render() instead of all of this extra code which does the same thing. Your current approach is a lot messier and doesn't leverage some of the better parts of Express, such as View Engine middleware.

Its simple to get it going in Express

// Tell Express to render the views from ./views
app.set('views', path.join(__dirname, 'views'));

// Set EJS as the View Engine
app.set('view engine', 'ejs');

The above code block will set EJS as the view engine for Express and use it for the res.render() function.

Then simply in your route you can do

app.get('/signin', function(req, res) {
  return res.render('signin');
});

or you could edit your home.signin() function

signin(req, res) {
  return res.render('signin');
}

Upvotes: 1

Related Questions