CODEWITHSUNDEEP
javaandroidscrollview
lenny
lenny

Reputation: 784

can't set Visibility of ScrollView

I made a XML element that automatically creates a Button, then a ScrollView with a LinearLayout inside. The Button, when pressed, is supposed to change color and change the Visibility of the ScrollView. Right now, it only changes the color of the Button, but the Text inside the Scroll View stays visible.

This worked before when I created the Button and ScrollView through XML and created onClickListeners through the onCreate() method in the main activity.

my code:

public class AccordionWidget extends LinearLayout{


    public AccordionWidget(Context c, AttributeSet attrs) {
        super(c, attrs);

        final Context context = c;

        final Button btn = new Button(context);
        final LinearLayout ll = new LinearLayout(context);
        final ScrollView sv = new ScrollView(context);

        TypedArray a = getContext().obtainStyledAttributes(attrs, R.styleable.accordion);

        LayoutParams btnparams = new LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT);
        btn.setText(a.getString(R.styleable.accordion_text));
        btn.setBackgroundColor(ContextCompat.getColor(context, R.color.button_not_pressed));
        LayoutParams llparams = new LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT);
        llparams.weight = 1f;
        LayoutParams swparams = new LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT);

        btn.setLayoutParams(btnparams);
        ll.setOrientation(LinearLayout.VERTICAL);
        ll.setLayoutParams(llparams);
        sv.setVisibility(View.GONE);
        sv.setLayoutParams(swparams);

        this.addView(sv);
        this.addView(btn);
        sv.addView(ll);

        btn.setOnClickListener(new OnClickListener() {
            boolean btnstate = false;
            @Override
            public void onClick(View v) {
                if (btnstate) {
                    btn.setBackgroundColor(ContextCompat.getColor(context, R.color.button_pressed));
                    sv.setVisibility(View.VISIBLE);
                    btnstate = false;
                } else {
                    btn.setBackgroundColor(ContextCompat.getColor(context, R.color.button_not_pressed));
                    sv.setVisibility(View.GONE);
                    btnstate = true;
                }
            }
        });

        a.recycle();
    }

}

Upvotes: 1

Views: 1635

Answers (3)

T D Nguyen
T D Nguyen

Reputation: 7613

Add color for background of sv. Try this:

final ScrollView sv = new ScrollView(context);
sv.setBackgroundColor(0xffffff);//make it not transparent :)

Because your code does not mention about the text so I suppose that the text is in different layer of the scrollview and if scrollview is on top of it, by setting the bgcolor it can blind the text.

Upvotes: 1

l7r7
l7r7

Reputation: 1328

Currently you're setting the visibility of the ScrollView but not the visibility of its children. You could try to hide all the children of the ScrollView individually like shown in this answer:

for ( int i = 0; i < sv.getChildCount();  i++ ){
    View view = sv.getChildAt(i);
    view.setVisibility(View.GONE);
}

So the idea is simple: get the children one by one and set the visibility. Of course you could do more stuff with the children if you need to.

Upvotes: 1

l7r7
l7r7

Reputation: 1328

Have you tried swapping these two lines:

sv.setVisibility(View.GONE);
sv.setLayoutParams(swparams);

Maybe setLayoutParams overrides the visibility set by setVisibility

Upvotes: 0

Related Questions