CODEWITHSUNDEEP
iosobjective-c
user979331
user979331

Reputation: 11961

dismissViewControllerAnimated is not dissmissing ViewController

So....I have a View Controller and when I press a button, another View Controller appears:

- (IBAction)searchButtonPressed:(id)sender {
    [self presentViewController:self.controllerSearch animated:YES completion:nil];
}

Inside view controller number 2 is a table view and when a row is selected in a table this code runs:

NSString *phrase = nil; // Document password (for unlocking most encrypted PDF files)

        NSString *filePath2 = filePath; assert(filePath2 != nil); // Path to first PDF file

        LazyPDFDocument *document = [LazyPDFDocument withDocumentFilePath:filePath2 password:phrase];

        if (document != nil) // Must have a valid LazyPDFDocument object in order to proceed with things
        {
            LazyPDFViewController *lazyPDFViewController = [[LazyPDFViewController alloc] initWithLazyPDFDocument:document];

            lazyPDFViewController.delegate = self; // Set the LazyPDFViewController delegate to self

#if (DEMO_VIEW_CONTROLLER_PUSH == TRUE)

            [self.navigationController pushViewController:lazyPDFViewController animated:YES];

#else // present in a modal view controller

            lazyPDFViewController.modalTransitionStyle = UIModalTransitionStyleCrossDissolve;
            lazyPDFViewController.modalPresentationStyle = UIModalPresentationFullScreen;

            [self presentViewController:lazyPDFViewController animated:YES completion:NULL];

#endif // DEMO_VIEW_CONTROLLER_PUSH
        }
        else // Log an error so that we know that something went wrong
        {
            NSLog(@"%s [LazyPDFDocument withDocumentFilePath:'%@' password:'%@'] failed.", __FUNCTION__, filePath2, phrase);
        }

Now I am using LazyPDFKit and it comes with this delegate method:

- (void)dismissLazyPDFViewController:(LazyPDFViewController *)viewController
{
    // dismiss the modal view controller
    [self dismissViewControllerAnimated:YES completion:NULL];

}

I put a break point and I can see my code goes into the delegate method, but the LazyPDFViewController does not go away.

I have tried the following:

[[[self presentingViewController] presentingViewController] dismissViewControllerAnimated:YES completion:nil];

but that takes me back a few view controllers to far.

Am I missing something?

Additional code in my first view Controller .h

@property (strong, nonatomic) UISearchController *controllerSearch;

and in first view controller .m

- (UISearchController *)controller {

    if (!_controllerSearch) {

        // instantiate search results table view
        UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"Storyboard" bundle:nil];
        LHFileBrowserSearch *resultsController = [storyboard instantiateViewControllerWithIdentifier:@"SearchResults"];

        // create search controller
        _controllerSearch = [[UISearchController alloc]initWithSearchResultsController:resultsController];
        _controllerSearch.searchResultsUpdater = self;

        // optional: set the search controller delegate
        _controllerSearch.delegate = self;

    }
    return _controllerSearch;
}

Upvotes: 5

Views: 3450

Answers (5)

Allen
Allen

Reputation: 6505

try this:

- (void)dismissLazyPDFViewController:(LazyPDFViewController *)viewController
{
    // dismiss the modal view controller
    [[viewController presentingViewController] dismissViewControllerAnimated:YES completion:nil];

}

your code : [[[self presentingViewController] presentingViewController] dismissViewControllerAnimated:YES completion:nil]; just went too far.

Upvotes: 1

OlDor
OlDor

Reputation: 1466

- (void)dismissLazyPDFViewController:(LazyPDFViewController *)viewController
{
    if (![NSThread isMainThread])
    {
        dispatch_async(dispatch_get_main_queue(), ^
                       {
                           [self dismissLazyPDFViewController:viewController];
                       });
        return;
    }
    if (viewController.navigationController)
    {
        [viewController.navigationController popViewControllerAnimated:YES];
    }
    else
    {
        [viewController dismissViewControllerAnimated:YES completion:nil];
    }
}

Upvotes: 0

Michael
Michael

Reputation: 1213

Looks like you need to the same macro for present as dismiss. So, you wrote

#if (DEMO_VIEW_CONTROLLER_PUSH == TRUE)

            [self.navigationController pushViewController:lazyPDFViewController animated:YES];

#else // present in a modal view controller

            lazyPDFViewController.modalTransitionStyle = UIModalTransitionStyleCrossDissolve;
            lazyPDFViewController.modalPresentationStyle = UIModalPresentationFullScreen;

            [self presentViewController:lazyPDFViewController animated:YES completion:NULL];

#endif // DEMO_VIEW_CONTROLLER_PUSH

You thus need

#if (DEMO_VIEW_CONTROLLER_PUSH == TRUE)

        [self.navigationController popViewControllerAnimated:YES];

    #else // presented in a modal view controller

                [self dismissViewControllerAnimated:YES completion:NULL];

    #endif // DEMO_VIEW_CONTROLLER_PUSH

It's possible that you have switched off the main thread and you can always add an assert to be check or, as has been suggested, use a dispatch_async to be certain.

NSAssert([NSThread isMainThread)];

I prefer the assert, when I know all the flows through a piece of code, since it shows my assumptions to the future me (or another) and does not leave code that looks like it knows something I do not (oh, they are using dispatch_async onto main so there must be some other thread magic going on deeper down).

Upvotes: 0

Raj Tandel
Raj Tandel

Reputation: 359

I just made the demo project based on your situation. And I am not facing any issue with it. So I think there might be some issue regarding how you are presenting the second controller.

In your button click, try this code:

- (IBAction)searchButtonPressed:(id)sender {
          UIStoryboard *main = [UIStoryboard storyboardWithName:@"Main" bundle:nil];
         //idSecondVC is the storyboard id of second view controller
        SecondVC *SecondVC = [main instantiateViewControllerWithIdentifier:@"idSecondVC"];
       [self presentViewController:SecondVC animated:YES completion:nil];

    }

And in your controller number 2, I just used the above code:

-(NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section
{
    return 10;

}

- (NSInteger)numberOfSectionsInTableView:(UITableView *)tableView {
    return 1;
}

-(UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath
{
    static NSString  *cellIdentifier = @"Cell";
    UITableViewCell  *cell = [tableView dequeueReusableCellWithIdentifier:cellIdentifier];
    cell.textLabel.text = [NSString stringWithFormat:@"Cell %ld",indexPath.row];
    return cell;

}

-(void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath
{
    [self openLazyPDF];
}

- (void)openLazyPDF
{
    NSString *phrase = nil; // Document password (for unlocking most encrypted PDF files)

    NSArray *pdfs = [[NSBundle mainBundle] pathsForResourcesOfType:@"pdf" inDirectory:nil];

    NSString *filePath = [pdfs firstObject]; assert(filePath != nil); // Path to first PDF file

    LazyPDFDocument *document = [LazyPDFDocument withDocumentFilePath:filePath password:phrase];

    if (document != nil) // Must have a valid LazyPDFDocument object in order to proceed with things
    {
        LazyPDFViewController *lazyPDFViewController = [[LazyPDFViewController alloc] initWithLazyPDFDocument:document];

        lazyPDFViewController.delegate = self; // Set the LazyPDFViewController delegate to self

#if (DEMO_VIEW_CONTROLLER_PUSH == TRUE)

        [self.navigationController pushViewController:lazyPDFViewController animated:YES];

#else // present in a modal view controller

        lazyPDFViewController.modalTransitionStyle = UIModalTransitionStyleCrossDissolve;
        lazyPDFViewController.modalPresentationStyle = UIModalPresentationFullScreen;

        [self presentViewController:lazyPDFViewController animated:YES completion:NULL];

#endif // DEMO_VIEW_CONTROLLER_PUSH
    }
    else // Log an error so that we know that something went wrong
    {
        NSLog(@"%s [LazyPDFDocument withDocumentFilePath:'%@' password:'%@'] failed.", __FUNCTION__, filePath, phrase);
    }
}

#pragma mark - LazyPDFViewControllerDelegate methods

- (void)dismissLazyPDFViewController:(LazyPDFViewController *)viewController
{
    // dismiss the modal view controller
    [self dismissViewControllerAnimated:YES completion:NULL];
}

And for me everything is working fine.

Upvotes: 0

davbryn
davbryn

Reputation: 7176

If you are pushing the view controller:

[self.navigationController pushViewController:lazyPDFViewController animated:YES];

Then the code in the delegate doesn't make sense, because it assumes it is a modal view controller that needs to be dismissed:

- (void)dismissLazyPDFViewController:(LazyPDFViewController *)viewController
{
    // dismiss the modal view controller
    [self dismissViewControllerAnimated:YES completion:NULL];

}

But you've added it to the navigation stack (I assume).

If you can't pop it again from the navigation controller at this point you are missing some code in your example.

Are you sure your delegate is firing on the main thread? Try:

- (void)dismissLazyPDFViewController:(LazyPDFViewController *)viewController
{
    dispatch_async(dispatch_get_main_queue(), ^{
        [self.navigationController popViewControllerAnimated:YES];
    });
}

Upvotes: 2

Related Questions