CODEWITHSUNDEEP
javascriptintellij-ideareplacemultilinestructural-search
Thomas Borghs
Thomas Borghs

Reputation: 13

Intellij Javascript multiline structural search and replace

In our project a lot of angular unit tests contain following syntax:

inject(['dependency1', 'dependency2', function(_dependency1_, _dependency2_) {
    dependency1 = _dependency1_;
    dependency2 = _dependency2_;
}]);

In tests the array which lists the dependencies with string values is obsolete, since this is only useful when using minification. So we issued a coding convention to change this syntax to:

inject(function(_dependency1_, _dependency2_) {
    dependency1 = _dependency1_;
    dependency2 = _dependency2_;
});

Now I've been replacing a couple of these in existing code when I came across them, but I've gotten really tired of doing this manually. So I'm trying to solve this in IntelliJ by using structural search and replace. This is my search template so far:

inject([$injection$, function($argument$) {
    $statement$;
}]);

with occurrences:

The replace template is defined as follows:

inject(function($argument$) {
    $statement$;
});

This does not work for the example I defined in the beginning however, it only matches and replaces correctly for a single line statement in the function body, so following example is replaced correctly:

inject(['dependency1', 'dependency2', function(_dependency1_, _dependency2_) {
    dependency1 = _dependency1_;
}]);

Am I missing something? When I check out the simple if-else example on the Jetbrains website I get the feeling that this should work.

I have tried removing the semicolon behind the $statement$ variable, this didn't match multiple lines and resulted in the semicolons being removed after replacement. I've also tried applying a regex expressions to the $statement$ variable, but these didn't help either.

((.*)=(.*);\n)+

didn't match, probably because the semicolon is filtered out by the IntelliJ structural search before the actual regex matching is performed.

(.*)=(.*)

matched, but it replaced with the same behaviour as without the regex.

Upvotes: 1

Views: 639

Answers (1)

Bas Leijdekkers
Bas Leijdekkers

Reputation: 26482

Matching multiple statements with a variable in JavaScript is currently broken because of a bug.

Upvotes: 1

Related Questions