CODEWITHSUNDEEP
c#androidjsonxamarinxamarin.android
user5677145
user5677145

Reputation:

Downloading info from JSON(Xamarin C#)

I am writing Android app in Xamarin C#.

I parse info from JSON and then show it in fields.

I use this code:

string url2 = "http://papajohn.pp.ua/?mkapi=getProductsByCat&cat_id=74";
        JsonValue json = await FetchAsync(url2);
 private async Task<JsonValue> FetchAsync(string url)
    {
        // Create an HTTP web request using the URL:
        HttpWebRequest request = (HttpWebRequest)HttpWebRequest.Create(new Uri(url));
        request.ContentType = "application/json";
        request.Method = "GET";

        // Send the request to the server and wait for the response:
        using (WebResponse response = await request.GetResponseAsync())
        {
            // Get a stream representation of the HTTP web response:
            using (Stream stream = response.GetResponseStream())
            {
                // Use this stream to build a JSON document object:
                JsonValue jsonDoc = await Task.Run(() => JsonObject.Load(stream));
                //dynamic data = JObject.Parse(jsonDoc[15].ToString);
                Console.Out.WriteLine("Response: {0}", jsonDoc.ToString());


                // Return the JSON document:
                return jsonDoc;
            }
        }
    }

But I have one problem. When I open Activity it freezes for 2-3 seconds and then all info shows in fields.

Can I make that data download smoothly. First field, then second etc.

And if I can, how?

Upvotes: 3

Views: 961

Answers (2)

Sreeraj
Sreeraj

Reputation: 2434

Your Async-Await usage in HttpWebRequest is correct. Wrong invocation of this method from Activity might be causing the UI freeze. I will explain how to invoke below.

I would also recommend to use ModernHttpClient library to speed up the API call. 

public static async Task<ServiceReturnModel> HttpGetForJson (string url)
    {

        using (var client = new HttpClient(new NativeMessageHandler())) 
        {

            try
            {
                using (var response = await client.GetAsync(new Uri (url))) 
                {
                    using (var responseContent = response.Content) 
                    {
                        var responseString= await responseContent.ReadAsStringAsync();
                        var result =JsonConvert.DeserializeObject<ServiceReturnModel>(responseString);
                    }
                }
            }
            catch(Exception ex) 
            {
               // Include error info here
            }
            return result;

        }

    }

You will need to include Xamarin Components ModernHttpClient and JSON.NET (Newtonsoft.Json)

Invoking this method from Activity without blocking UI

protected override void OnCreate (Bundle bundle)
    {
        base.OnCreate (bundle);

        SetContentView (Resource.Layout.Main);
        // After doing initial Setups
        LoadData();
     }

// This method downloads Json asynchronously without blocking UI and without showing a Pre-loader.
async Task LoadData()
    {
        var newRequestsResponse =await ServiceLayer.HttpGetForJson (newRequestsUrl);
      // Use the data here or show proper error message
    }

 // This method downloads Json asynchronously without blocking UI and shows a Pre-loader while downloading.
async Task LoadData()
    {
        ProgressDialog progress = new ProgressDialog (this,Resource.Style.progress_bar_style);
        progress.Indeterminate = true;
        progress.SetProgressStyle (ProgressDialogStyle.Spinner);
        progress.SetCancelable (false);
        progress.Show ();
        var newRequestsResponse =await ServiceLayer.HttpGetForJson (newRequestsUrl);
        progress.Dismiss ();
      // Use the data here or show proper error message
    }

Material type Loader Style. To be included in Resources/Values/Style.xml

<style name="progress_bar_style">
<item name="android:windowFrame">@null</item>
<item name="android:windowBackground">@android:color/transparent</item>
<item name="android:windowIsFloating">true</item>
<item name="android:windowContentOverlay">@null</item>
<item name="android:windowTitleStyle">@null</item>
<item name="android:windowAnimationStyle">@android:style/Animation.Dialog</item>
<item name="android:windowSoftInputMode">stateUnspecified|adjustPan</item>
<item name="android:backgroundDimEnabled">true</item>
<item name="android:background">@android:color/transparent</item>

Upvotes: 1

SharpMobileCode
SharpMobileCode

Reputation: 938

I would recommend implementing the proper usage of async/await in C#, and switching to HttpClient, which also implements the proper usage of async/await. Below is a code sample that will retrieve your Json outside of the UI Thread:

var url2 = "http://papajohn.pp.ua/?mkapi=getProductsByCat&cat_id=74";
var jsonValue = await FetchAsync(url2);

private async Task<JsonValue> FetchAsync(string url)
{
   System.IO.Stream jsonStream;
   JsonValue jsonDoc;

   using(var httpClient = new HttpClient())
   {
     jsonStream = await httpClient.GetStreamAsync(url);
     jsonDoc = JsonObject.Load(jsonStream);
   }

   return jsonDoc;
}

If you're writing your code in an Android project, you'll need to add the System.Net.Http DLL as a reference. If you're writing your code in aPCL, then you'll need to install the Microsoft Http Client Libraries Nuget Package. For even improve performance, I recommend using ModernHttpClient, which can also be installed from Nuget.

Upvotes: 1

Related Questions