CODEWITHSUNDEEP
javac#androidsockets
Salman Younas
Salman Younas

Reputation: 350

Socket Programming: Delay

I have a server app written in C# for Windows. I have a client app for android. I want to send data continuously from client to server in an infinite loop. The data is being sent but sometimes, there is a bad delay. I'm really stuck at it. Here's my client side code:

new Thread(new Runnable() {
        public void run() {
            Socket socket = null;
            PrintWriter out = null;
            while(true) {
                try {
                    socket = new Socket(IP, PORT);
                    out = new PrintWriter(socket.getOutputStream(), true);
                    out.println(msg);
                    socket.close();
                } catch (IOException e) {
                    e.printStackTrace();
                }
            }
        }
    }).start();

Any idea why is there a delay?

Upvotes: 1

Views: 2158

Answers (2)

Knossos
Knossos

Reputation: 16058

Your problem is that you are initializing the socket every single iteration of your while loop.

new Thread(new Runnable() {
    public void run() {
        Socket socket = null;
        PrintWriter out = null;
        while(true) {
            try {
                socket = new Socket(IP, PORT);
                out = new PrintWriter(socket.getOutputStream(), true);
                out.println(msg);
                socket.close();
            } catch (IOException e) {
                e.printStackTrace();
            }
        }
    }
}).start();

Refactor it out of the loop, like this:

new Thread(new Runnable() {
    public void run() {
        Socket socket = new Socket(IP, PORT);
        PrintWriter out = new PrintWriter(socket.getOutputStream(), true);
        while(true) {
            try {
                out.println(msg);
            } catch (IOException e) {
                e.printStackTrace();
            }
        }
        socket.close();
    }
}).start();

Unless that is by design, in which case, why?

Upvotes: 2

Angel Sanchis
Angel Sanchis

Reputation: 57

It seems the code is correct. The lag may be caused not only by the application but also by the network status.

Try to ping to the router from both devices and see if you are having lag spikes due to the wireless conection. If you see high lag in pings the problem is in the connection, not in the application.

Upvotes: 0

Related Questions