C# with repository pattern and dependency injection (Autofac)

Question

I started to build a C# MVC web application with repository pattern and Autofac dependency injection. For database, I'm using MongoDB as database.

I need help to review my code and error that I faced now :

None of the constructors found with 'Autofac.Core.Activators.Reflection.DefaultConstructorFinder' on type 'ErpWebApp.Services.Implementer.AccountServices' can be invoked with the available services and parameters: Cannot resolve parameter 'ErpWebApp.Domain.IDbRepository1[ErpWebApp.Domain.Entities.AccountCategories] accCategoriesRepository' of constructor 'Void .ctor(ErpWebApp.Domain.IDbRepository1[ErpWebApp.Domain.Entities.AccountCategories])'.

Details of my code as below, please let me know if any other information needed.

This is my Entities

public interface IEntityBase
{
    TId Id { get; set; }
}

public interface IAuditBase : IEntityBase
{
    bool IsActive { get; set; }
    string CreatedBy { get; set; }
    BsonDateTime CreatedTime { get; set; }
    string ModifiedBy { get; set; }
    BsonDateTime ModifiedTime { get; set; }
}

public class AccountCategories : IAuditBase
{
    public AccountCategories()
    {
        IsActive = true;
        CreatedTime = DateTime.UtcNow;
        ModifiedTime = DateTime.UtcNow;
    }

    #region Inherit
    [BsonId]
    public ObjectId Id { get; set; }

    public bool IsActive { get; set; }
    public string CreatedBy { get; set; }
    public BsonDateTime CreatedTime { get; set; }
    public string ModifiedBy { get; set; }
    public BsonDateTime ModifiedTime { get; set; }
    #endregion

    #region Member
    public string Name { get; set; }
    #endregion

}

This is my Repository

public interface IDbRepository where T: class
{
    IMongoDatabase _database { get; }
    IMongoCollection _collection { get; }

    IEnumerable List { get; }

    Task> GetAllAsync();
    //Task GetOneAsync(T context);
    //Task GetOneAsync(string id);
}

public class DbRepository where T : IAuditBase 
{
    public static IMongoDatabase _database;
    public static IMongoCollection _collection;

    public DbRepository()
    {
        GetDatabase();
        GetCollection();
    }

    private void GetDatabase()
    {
        var _dbName = ConfigurationManager.AppSettings["MongoDbDatabaseName"];
        var _connectionString = ConfigurationManager.AppSettings["MongoDbConnectionString"];

        _connectionString = _connectionString.Replace("{DB_NAME}", _dbName);

        var client = new MongoClient(_connectionString);
        _database = client.GetDatabase(_dbName);
    }

    private void GetCollection()
    {
        _collection = _database.GetCollection(typeof(T).Name);
    }

    private MongoCollectionBase GetCollection()
    {
        var _result = _database.GetCollection(typeof(T).Name) as MongoCollectionBase;

        return _result;
    }

    public IEnumerable List()
    {
        var _result = GetCollection().AsQueryable().ToList(); ;

        return _result;
    }

    public async Task> GetAllAsync(IMongoCollection collection)
    {
        return await collection.Find(f => true).ToListAsync();
    }

This is my Services

public interface IAccountServices
{
    IEnumerable GetAll();
}

public class AccountServices :IAccountServices
{
    private readonly IDbRepository _accCategoriesRepository;

    public AccountServices(IDbRepository accCategoriesRepository)
    {
        _accCategoriesRepository = accCategoriesRepository;
    }

    public IEnumerable GetAll()
    {
        var _result = _accCategoriesRepository.GetAllAsync().Result;

        return _result;
    }
}

This is my Helper class

public interface IAccountHelper
{
    DataTableResult GetData(DataTableParameters param);
}

public class AccountHelper : IAccountHelper
{
    private readonly IAccountServices _accountService;

    public AccountHelper(IAccountServices accountServices)
    {
        _accountService = accountServices;
    }

    public DataTableResult GetData(DataTableParameters param)
    {
        int totalRecords = 0;

        var data = _accountService.GetAll();

        int totalDisplayRecords = data.Count();
        totalRecords = totalDisplayRecords;

        // testing
        return new DataTableResult()
        {
            aaData = null, 
            iTotalDisplayRecords = 0,
            iTotalRecords = 0
        };

    }
}

This is my controller

public class AccountController : Controller
{
    private readonly IAccountHelper _helper;
    // GET: UserTypes
    public AccountController(IAccountHelper helper)
    {
        _helper = helper;
    }
    // GET: Account
    public ActionResult Index()
    {
        return View();
    }

    public JsonResult Get(DataTableParameters param)
    {
        var data = _helper.GetData(param);
        return Json(data, JsonRequestBehavior.AllowGet);
    }
}

This is my AutoFac

public class DependencyInjectionConfig
{
    public static IContainer Build()
    {
        var builder = new ContainerBuilder();
        builder.RegisterFilterProvider();

        builder.RegisterControllers(typeof(MvcApplication).Assembly);

        builder.RegisterGeneric(typeof(DbRepository<>)).As(typeof(DbRepository<>));

        //Service
        builder.RegisterType().As();

        //Helpers
        builder.RegisterType().As();

        return builder.Build();
    }
}

Global.asax

protected void Application_Start()
{
    AreaRegistration.RegisterAllAreas();
    FilterConfig.RegisterGlobalFilters(GlobalFilters.Filters);
    RouteConfig.RegisterRoutes(RouteTable.Routes);
    BundleConfig.RegisterBundles(BundleTable.Bundles);

    var container = DependencyInjectionConfig.Build();

    DependencyResolver.SetResolver(new AutofacDependencyResolver(container));
}

Web.config

NightOwl888 · Accepted Answer

AccountServices expects type IDbRepository. But you have registered DBRepository:

builder.RegisterGeneric(typeof(DBRepository<>)).As(typeof(DBRepository<>));

Instead, you should change that line to:

builder.RegisterGeneric(typeof(DBRepository<>)).As(typeof(IDbRepository<>));

Or perhaps:

builder.RegisterAssemblyTypes(AppDomain.CurrentDomain.GetAssemblies())
            .AsClosedTypesOf(typeof(IDbRepository<>), true)
            .AsImplementedInterfaces();

Note also that the casing of B differs between IDbRepository and DBRepository, which is confusing.

C# with repository pattern and dependency injection (Autofac)

Answers (2)

Related Questions