CODEWITHSUNDEEP
javamavenspring-mvcspring-bootspring-restcontroller
gkc123
gkc123

Reputation: 522

REST Controller not recognizing GET request in Spring Boot App

I am trying to implement simple demo MVC app with Spring Boot but I get 404 error while executing the application. The uri is http://localhost:8080/ which is to display all the rows in a table called circle.

Maven Java Project:

Maven Java Project Structure

Application.java

package com.nomad.dubbed.app;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;

@SpringBootApplication
public class Application  {
    
    public static void main(String[] args){
        SpringApplication.run(Application.class, args);
    }

}

CircleController.java

package com.nomad.dubbed.controller;

import java.util.List;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RequestMethod;
import org.springframework.web.bind.annotation.RestController;

import com.nomad.dubbed.dao.CircleService;
import com.nomad.dubbed.model.Circle;

@RestController
@RequestMapping("/")
public class CircleController {
    @Autowired
    private CircleService circleService;
    
    @RequestMapping(method=RequestMethod.GET)
    public List<Circle> getAll() {
        return circleService.getAll();
    }

}

CircleRepository.java

package com.nomad.dubbed.dao;

import org.springframework.data.jpa.repository.JpaRepository;
import org.springframework.stereotype.Repository;

import com.nomad.dubbed.model.Circle;

@Repository
public interface CircleRepository extends JpaRepository<Circle, Integer> {

}

CircleService.java

package com.nomad.dubbed.dao;

import java.util.List;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Propagation;
import org.springframework.transaction.annotation.Transactional;

import com.nomad.dubbed.model.Circle;

@Service
public class CircleService {
    @Autowired
    private CircleRepository circleRepository;
    
    @Transactional(propagation=Propagation.REQUIRED)
    public List<Circle> getAll(){
        return circleRepository.findAll();
    }

}

Circle.java

package com.nomad.dubbed.model;

import javax.persistence.Entity;
import javax.persistence.GeneratedValue;
import javax.persistence.GenerationType;
import javax.persistence.Id;
import javax.persistence.Table;

@Entity
@Table(name="circle")
public class Circle {
    @Id
    @GeneratedValue(strategy=GenerationType.IDENTITY)
    private int id;
    private String name;
    
    public Circle(int id, String name) {
        super();
        this.id = id;
        this.name = name;
    }
    
    public int getId() {
        return id;
    }
    public void setId(int id) {
        this.id = id;
    }
    public String getName() {
        return name;
    }
    public void setName(String name) {
        this.name = name;
    }

}

application.properties

spring.datasource.url=jdbc:derby://localhost:1527/db
spring.datasource.driverClassName=org.apache.derby.jdbc.ClientDriver

logging.level.org.springframework.web:DEBUG
logging.level.org.hibernate:DEBUG

pom.xml

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.nomad.dubbed</groupId>
  <artifactId>spring-boot-mvc</artifactId>
  <version>0.0.1-SNAPSHOT</version>
  
  
    <properties>
        <derby-client.version>10.11.1.1</derby-client.version>
    </properties>

    <parent>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-parent</artifactId>
        <version>1.3.3.RELEASE</version>
        <relativePath />
    </parent>
    <dependencies>
        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter</artifactId>
        </dependency>
        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-web</artifactId>
        </dependency>
        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-actuator</artifactId>
        </dependency>
        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-remote-shell</artifactId>
        </dependency>
        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-data-jpa</artifactId>
        </dependency>
        
        <dependency>
            <groupId>org.apache.derby</groupId>
            <artifactId>derbyclient</artifactId>
            <version>${derby-client.version}</version>
        </dependency>

        <dependency>
            <groupId>junit</groupId>
            <artifactId>junit</artifactId>
            <scope>test</scope>
        </dependency>
    </dependencies>
    <build>
        <finalName>spring-boot-mvc</finalName>
        <plugins>
            <plugin>
                <groupId>org.springframework.boot</groupId>
                <artifactId>spring-boot-maven-plugin</artifactId>
            </plugin>
        </plugins>
    </build>
    
</project>

Database is up and running, there are 5 rows in the table circle:

enter image description here

The default uri (/beans, /health..) works fine but the implemented controller is not recognized. There is no error of such displayed in the console, below is the dump of logs printed in console after I send the request.

2016-05-03 14:17:26.594 DEBUG 659 --- [nio-8080-exec-3] o.s.web.servlet.DispatcherServlet        : DispatcherServlet with name 'dispatcherServlet' processing GET request for [/]
2016-05-03 14:17:26.596 DEBUG 659 --- [nio-8080-exec-3] s.w.s.m.m.a.RequestMappingHandlerMapping : Looking up handler method for path /
2016-05-03 14:17:26.596 DEBUG 659 --- [nio-8080-exec-3] s.w.s.m.m.a.RequestMappingHandlerMapping : Did not find handler method for [/]
2016-05-03 14:17:26.597 DEBUG 659 --- [nio-8080-exec-3] o.s.w.s.handler.SimpleUrlHandlerMapping  : Matching patterns for request [/] are [/**]
2016-05-03 14:17:26.597 DEBUG 659 --- [nio-8080-exec-3] o.s.w.s.handler.SimpleUrlHandlerMapping  : URI Template variables for request [/] are {}
2016-05-03 14:17:26.597 DEBUG 659 --- [nio-8080-exec-3] o.s.w.s.handler.SimpleUrlHandlerMapping  : Mapping [/] to HandlerExecutionChain with handler [ResourceHttpRequestHandler [locations=[ServletContext resource [/], class path resource [META-INF/resources/], class path resource [resources/], class path resource [static/], class path resource [public/]], resolvers=[org.springframework.web.servlet.resource.PathResourceResolver@6c13019c]]] and 1 interceptor
2016-05-03 14:17:26.597 DEBUG 659 --- [nio-8080-exec-3] o.s.web.servlet.DispatcherServlet        : Last-Modified value for [/] is: -1
2016-05-03 14:17:26.597 DEBUG 659 --- [nio-8080-exec-3] o.s.web.servlet.DispatcherServlet        : Null ModelAndView returned to DispatcherServlet with name 'dispatcherServlet': assuming HandlerAdapter completed request handling
2016-05-03 14:17:26.597 DEBUG 659 --- [nio-8080-exec-3] o.s.web.servlet.DispatcherServlet        : Successfully completed request
2016-05-03 14:17:26.597 DEBUG 659 --- [nio-8080-exec-3] o.s.web.servlet.DispatcherServlet        : DispatcherServlet with name 'dispatcherServlet' processing GET request for [/error]
2016-05-03 14:17:26.600 DEBUG 659 --- [nio-8080-exec-3] s.w.s.m.m.a.RequestMappingHandlerMapping : Looking up handler method for path /error
2016-05-03 14:17:26.600 DEBUG 659 --- [nio-8080-exec-3] s.w.s.m.m.a.RequestMappingHandlerMapping : Returning handler method [public org.springframework.web.servlet.ModelAndView org.springframework.boot.autoconfigure.web.BasicErrorController.errorHtml(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse)]
2016-05-03 14:17:26.600 DEBUG 659 --- [nio-8080-exec-3] o.s.web.servlet.DispatcherServlet        : Last-Modified value for [/error] is: -1
2016-05-03 14:17:26.601 DEBUG 659 --- [nio-8080-exec-3] o.s.w.s.v.ContentNegotiatingViewResolver : Requested media types are [text/html, text/html;q=0.8] based on Accept header types and producible media types [text/html])
2016-05-03 14:17:26.601 DEBUG 659 --- [nio-8080-exec-3] o.s.w.s.v.ContentNegotiatingViewResolver : Returning [org.springframework.boot.autoconfigure.web.ErrorMvcAutoConfiguration$SpelView@2f5f8d71] based on requested media type 'text/html'
2016-05-03 14:17:26.601 DEBUG 659 --- [nio-8080-exec-3] o.s.web.servlet.DispatcherServlet        : Rendering view [org.springframework.boot.autoconfigure.web.ErrorMvcAutoConfiguration$SpelView@2f5f8d71] in DispatcherServlet with name 'dispatcherServlet'
2016-05-03 14:17:26.601 DEBUG 659 --- [nio-8080-exec-3] o.s.web.servlet.DispatcherServlet        : Successfully completed request

Rest App Browser

Upvotes: 13

Views: 62894

Answers (11)

Nisha Sinha
Nisha Sinha

Reputation: 160

The issue is Spring boot scans the package where the file with main method is located.

In my case: demo.example package. So, the controllers should be created inside this package only to be scanned. enter image description here

When the main file was under com.example.demo package, it was not identifying StudentController.

Upvotes: 1

Ankita Chaturvedi
Ankita Chaturvedi

Reputation: 191

We should not use @ComponentScan annotation with @SpringBootApplication, as that's not the right practice. @SpringBootApplication is a combination of 3 annotations: @ComponentScan, @EnableAutoConfiguration and @Configuration.

Main class which has the @SpringBootApplication annotation should be in parent/super package.

e.g. - com.spring.learning is a parent package and its children are com.spring.learning.controller, com.spring.learning.service, com.spring.learning.pojo

Hence it scans its package and sub packages.

This is the best practice – project layout or structure is a prominent concept in Spring Boot.

Upvotes: 14

BAGEERADHA
BAGEERADHA

Reputation: 21

please check that the your controller classes are in sub packages.

For example, if the main class is com.myapp package, then controller class is either in the same package or is in sub package like com.myapp.controllers. Spring Framework will scan root package and then all its sub packages. In this case things will just work and you would not need to use @ComponentScan.

If you place the main class in com.myapp and other beans/controllers which you want to be autowired you place in a different package like com.beans which is not a sub package of com.myapp, then you will experience an issue when beans could not be found.

Thanks! Bageeradha

Upvotes: 2

Aks00747
Aks00747

Reputation: 1

actually springboots scans all of its components under you core package like example:

package com.nomad.dubbed.app;

if you add controllers, services, dao packages under com.nomad.dubbed.app.controllers, com.nomad.dubbed.app.services, com.nomad.dubbed.app.dao.

then you can easily run your rest controller, but if you add all packages parallel to your core springboot package like com.nomad.dubbed.controllers, com.nomad.dubbed.services.

then you need to scan for @ComponentScan({"com.nomad.dubbed.controllers","com.nomad.dubbed.services"})

if you choose to go for componentscan then you have to also scan for springboot application package as well.

so best way is create all the packages under spring boot application dubbed.app.xyz...

Upvotes: 0

Johna
Johna

Reputation: 1894

This what happens behind.

@SpringBootApplication annotation is a combination of @Configuration @EnableAutoConfiguration @ComponentScan.

@ComponentScan without arguments tells the framework to find components/beans in the same package and its sub-packages.

Your Application class which is annotated with @SpringBootApplication is in the package com.nomad.dubbed.app. So it scans that package and its sub-packages under it (like com.nomad.dubbed.app.*). But your CircleController is inside package com.nomad.dubbed.controller which is not scanned by default. Your repositories too fall outside the default scan packages, so they too will not be discovered by spring framework.

So what to do now?, you have two options.

Option 1

Move the Application class to the top directory(package). In your case com.nomad.dubbed package. Then, since all controllers and other repositories are in sub-packages, they will be discovered by the framework.

Option 2

Use @ComponentScan annotation with basePackages argument, along with the @SpringBootApplication in your Application class like below.

@SpringBootApplication
@ComponentScan(basePackages="com.nomad.dubbed")
public class Application  {

    public static void main(String[] args){
        SpringApplication.run(Application.class, args);
    }
}

Upvotes: 5

Pooja
Pooja

Reputation: 63

I had a similar issue. Adding the annotation @SpringBootApplication(scanBasePackages={"com.nomad.dubbed"}) on the Application class worked for me.

Upvotes: 0

Chinmay Biswal
Chinmay Biswal

Reputation: 393

In my opinion, this visibility problem comes when we leave the component scan to Spring which has a particular way of looking for the classes using standard convention. In this scenario as the Starter class(Application)is in com.nomad.dubbed.app package, putting Controller one level below will help Spring to find the classes using the default component scan mechanism. Putting CircleController under com.nomad.dubbed.app.controller should solve the issue.

Upvotes: 0

jstuartmilne
jstuartmilne

Reputation: 4488

Could you try adding the @ResponseBody Annotation

@RequestMapping(method=RequestMethod.GET)
@ResponseBody
    public List<Circle> getAll() {
        return circleService.getAll();
    }

Upvotes: 0

mani
mani

Reputation: 1101

I had the same problem and I added @ComponentScan(basePackages = "package.name") in the Application class. After that my rest controller was recognized.

package com.nomad.dubbed.app;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;

@SpringBootApplication
@ComponentScan(basePackages = "com.spring.basepkg")
public class Application  {

    public static void main(String[] args){
        SpringApplication.run(Application.class, args);
    }

}

Upvotes: 0

gkc123
gkc123

Reputation: 522

I have to research more why spring - boot failed to recognize controller with the original package structure. I dumped all the java classes into one package and finally got the demo project running.

Modified Java Project Structure:

Modified Java Project Structure

The CircleController.java class was also modified. I have all the records deleted from the circle table without mentioning specific Request Method, method=RequestMethod.GET.

package com.nomad.dubbed.app;

import java.util.List;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RequestMethod;
import org.springframework.web.bind.annotation.RestController;

@RestController
public class CircleController {
    @Autowired
    private CircleService circleService;

    @RequestMapping(value="/circles", method=RequestMethod.GET)
    public List<Circle> getAll() {
        return circleService.getAll();
    }

}

Upvotes: 0

Lutz M&#252;ller
Lutz M&#252;ller

Reputation: 584

use a different url for your controller. "/" in spring-boot maps to static resources located in META-INF/resources and src/main/resources/static/ .

edit: forget above and do the following in your application class:

Application.java

package com.nomad.dubbed.app;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;

@SpringBootApplication
@ComponentScan("com.nomad.dubbed")
public class Application  {

    public static void main(String[] args){
        SpringApplication.run(Application.class, args);
    }

}

your rest controller is not discovered by spring-boots component scan. according to this doc http://docs.spring.io/spring-boot/docs/current/reference/html/… spring scans the packages below the package where the class with the @SpringBootApplication annotation resides. your controller is located in a parallel package.

Upvotes: 27

Related Questions