Fragment overlapping another fragment instead of replacing it

Question

The setup I have is a main_activity fragment that just has welcome text, and when you tap the start button, it's supposed to switch fragments. Instead of replacing the current fragment, it just overlays it on top of the main_activity fragment and won't allow me to perform the action associated with the new fragment.

Main Activity example

quote_fragment overlapping main activity

activity_main.xml:

ActivityMain.java

package me.alexoladele.quotebook;

import android.os.Bundle;
import android.support.v4.app.FragmentTransaction;
import android.support.v7.app.AppCompatActivity;
import android.view.View;
import android.widget.Button;
import android.widget.TextView;


public class MainActivity extends AppCompatActivity {
    int count = 0;
    final QuoteFragment quoteFragment = new QuoteFragment();

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);


        final Button startButton = (Button) findViewById(R.id.start_button);
        final TextView welcomeText = (TextView) findViewById(R.id.welcome_screen_text);
        if (startButton != null)
            startButton.setOnClickListener(new View.OnClickListener() {
                @Override
                public void onClick(View v) {
                    startSecondFragment(); // start your fragment from MainActivity
                    //startButton.setVisibility(v.GONE);
                    //welcomeText.setVisibility(v.GONE);
                }
            });


    }

    // This method will be in charge of handling your second fragment
    private void startSecondFragment() {
        android.support.v4.app.FragmentManager manager = getSupportFragmentManager();
        manager.beginTransaction()
                .setTransition(FragmentTransaction.TRANSIT_FRAGMENT_OPEN)
                .replace(R.id.main_activity, quoteFragment)
                .commit();



    }


}

quote_fragment.xml:

QuoteFragment.java:

package me.alexoladele.quotebook;

import android.os.Bundle;
import android.view.LayoutInflater;
import android.view.MotionEvent;
import android.view.View;
import android.view.ViewGroup;
import android.widget.FrameLayout;
import android.widget.TextView;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;

//import android.support.v4.app.Fragment;

public class QuoteFragment extends android.support.v4.app.Fragment {
    int count = 0;

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {
        View v = inflater.inflate(R.layout.quote_fragment,container, false);

        FrameLayout touch = (FrameLayout) v.findViewById(R.id.main_activity);
        final TextView quoteText = (TextView) v.findViewById(R.id.quote);


        // Makes quotes array
        //region Description
        String[] quotes = {
                (Quotes go here, but I didn't put them here to save space)
        };
        //endregion

        // Put quotes array into arraylist
        final List quoteList = new ArrayList<>(Arrays.asList(quotes));

        //
        if (touch != null)
            touch.setOnClickListener(new View.OnClickListener() {
                @Override
                public void onClick(View v) {
                    if (count >= quoteList.size()) {
                        count = 0;
                    }
                    Quote q = new Quote("");
                    q.setQuote(quoteList.get(count));

                    quoteText.setText(q.getQuote());
                    count++;

                    v.setOnTouchListener(new View.OnTouchListener() {
                        @Override
                        public boolean onTouch(View v, MotionEvent event) {
                            return true;
                        }
                    });

                }
            });



        // Inflate the layout for this fragment
        return inflater.inflate(R.layout.quote_fragment, container, false);
    }




}

welcome_screen_fragment:

WelcomeScreen.java:

package me.alexoladele.quotebook;

import android.content.Context;
import android.net.Uri;
import android.os.Bundle;
import android.support.v4.app.Fragment;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;


/**
 * A simple {@link Fragment} subclass.
 * Activities that contain this fragment must implement the
 * {@link WelcomeScreen.OnFragmentInteractionListener} interface
 * to handle interaction events.
 * Use the {@link WelcomeScreen#newInstance} factory method to
 * create an instance of this fragment.
 */
public class WelcomeScreen extends Fragment {
    // TODO: Rename parameter arguments, choose names that match
    // the fragment initialization parameters, e.g. ARG_ITEM_NUMBER
    private static final String ARG_PARAM1 = "param1";
    private static final String ARG_PARAM2 = "param2";

    // TODO: Rename and change types of parameters
    private String mParam1;
    private String mParam2;

    //private OnFragmentInteractionListener mListener;

    public WelcomeScreen() {
        // Required empty public constructor
    }

    /**
     * Use this factory method to create a new instance of
     * this fragment using the provided parameters.
     *
     * @param param1 Parameter 1.
     * @param param2 Parameter 2.
     * @return A new instance of fragment WelcomeScreen.
     */
    // TODO: Rename and change types and number of parameters
    public static WelcomeScreen newInstance(String param1, String param2) {
        WelcomeScreen fragment = new WelcomeScreen();
        Bundle args = new Bundle();
        args.putString(ARG_PARAM1, param1);
        args.putString(ARG_PARAM2, param2);
        fragment.setArguments(args);
        return fragment;
    }

    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        if (getArguments() != null) {
            mParam1 = getArguments().getString(ARG_PARAM1);
            mParam2 = getArguments().getString(ARG_PARAM2);
        }
    }

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {
        // Inflate the layout for this fragment
        return inflater.inflate(R.layout.welcome_screen_fragment, container, false);
    }

   /* // TODO: Rename method, update argument and hook method into UI event
    public void onButtonPressed(Uri uri) {
        if (mListener != null) {
            mListener.onFragmentInteraction(uri);
        }
    }

    @Override
    public void onAttach(Context context) {
        super.onAttach(context);
        if (context instanceof OnFragmentInteractionListener) {
            mListener = (OnFragmentInteractionListener) context;
        } else {
            throw new RuntimeException(context.toString()
                    + " must implement OnFragmentInteractionListener");
        }
    }

    @Override
    public void onDetach() {
        super.onDetach();
        mListener = null;
    }

    *//**
     * This interface must be implemented by activities that contain this
     * fragment to allow an interaction in this fragment to be communicated
     * to the activity and potentially other fragments contained in that
     * activity.
     * 
     * See the Android Training lesson Communicating with Other Fragments for more information.
     *//*
    public interface OnFragmentInteractionListener {
        // TODO: Update argument type and name
        void onFragmentInteraction(Uri uri);
    }*/
}

Jeffrey Blattman · Accepted Answer

Don't replace your top-level view group. Create an empty frame layout inside of the top-level frame layout and use that as the ID to replace.

If you have elements in the main layout you no longer want visible you'll have to hide them (or use a fragment to show them in the first place which will get replaced).

Fragment overlapping another fragment instead of replacing it

Answers (1)

Related Questions