CODEWITHSUNDEEP
c#entity-frameworkasynchronoustask
Chris
Chris

Reputation: 925

EF Async Methods - best practices / improvements

Sorry for a subjective question like this:

I current have a sequential loading method which was extremely slow, I have converted this into a async method:

    public async void LoadData(int releaseId, int projectId, bool uiThread)

Within this method I start up an Await task (and set the ConfigureAwait to be false) as it does not need to capture and resume from this context.

     await Task.Run(() =>
     { 
         //make several DB calls as below 

     }).ConfigureAwait(False);

Within this task I make several async calls to EF / the database, each call looks something like this: 

    public async virtual Task<List<X>> FindXAsync()
    {
        var q = from c in context.X
                select c;
        return await q.ToListAsync();
    }

But in the task I am awaiting the response by using result see below:

    X = sm.FindXAsync().Result;

From my limited knowledge of using asynchronous programming with EF would each call run sequentially from inside the task?

Will the current set up return multiple return sets concurrently or would I have to create multiple tasks and await them separatly.

Again sorry for the vague question but i'm sure you guys are a lot more experienced on this topic than me ^^

Edit: I release there wasn't really a proper question in there, I guess what I am wondering is would x,y and z return concurrently or sequentially from within the task.

     await Task.Run(() =>
     {
          x = sm.FindXAsync().Result;

          y = new ObservableCollection<Y>(sm.FindYAsync().Result);

          z = new ObservableCollection<Z>(sm.FindZAsync().Result);
     }).ConfigureAwait(False)

Thanks,

Chris

Upvotes: 0

Views: 517

Answers (1)

Radin Gospodinov
Radin Gospodinov

Reputation: 2323

Yes, the will run sequentially when you use the Result property. Also they will run sequentially with the following code: `

    x = await sm.FindXAsync().ConfigureAwait(False);

    y = new ObservableCollection<Y>( await sm.FindYAsync().ConfigureAwait(False));

    z = new ObservableCollection<Z>(await sm.FindZAsync().ConfigureAwait(False));

Also update 

 public async void LoadData to return Task ->  `public async Task LoadData`.

If you want to run all code in parallel add the taks in an array and then call await Task.WhenAll(tasks)

Upvotes: 1

Related Questions