CODEWITHSUNDEEP
excelvba
Jamie
Jamie

Reputation: 7421

How can I correct this "runtime error 1004 method range of object _global failed" error?

I'm trying to open a file based on a named reference in my excel work book. My code:

Sub OpenCustomerData()
    wb = ActiveWorkbook.Name

    reference = "[" & wb & "]Individual" & "!customer_id"

    customer_id = Range(reference)

    Workbooks.Open Filename:=customer_id.Value & ".csv"
End Sub

Stepping through the code, the reference looks to me to be right: [MyBook.xlsm]Individual!customer_id but I get the 1004 error when I pass that as an argument to the Range() function.

Why?

Upvotes: 0

Views: 724

Answers (3)

SierraOscar
SierraOscar

Reputation: 17637

If you're in the active workbook anyway, then just use the sheet name and qualify the range:

Sub OpenCustomerData()
    Workbooks.Open Filename:=Sheets("Individual").Range("customer_id").Value
End Sub

Upvotes: 1

user4039065
user4039065

Reputation:

If you want to use customer_id as a range (aka cell) reference and retrieve the Range.Value property out of it in your concatenated string filename then you need to Set it.

SET customer_id = Range(reference)
Workbooks.Open Filename:=customer_id.Value & ".csv"

If you just want customer_id as the value of the range to start with then you do not need to Set it, but you use it as a variable with a stored value, not as a Range object.

customer_id = Range(reference).VALUE
Workbooks.Open Filename:=customer_id & ".csv"

Not declaring customer_id demonstrates ambiguity as to how it should be used.

Upvotes: 0

CaffeinatedMike
CaffeinatedMike

Reputation: 1607

You could set the names range to a variable like so

Set CustID = ActiveWorkbook.Names("customer_id").RefersToRange
Workbooks.Open Filename:=CustID.Value & ".csv"

Upvotes: 1

Related Questions