CODEWITHSUNDEEP
c#
balexander
balexander

Reputation: 24399

C# Updating Data Issue

I am currently using one button for inserting/updating content within a table. It then takes the uploaded CSV and inserts or updates it into a data table depending on whether the row exists or not.

Here is the code fired after the button's OnClick:

if (ExcelDDL.SelectedValue == "Time Points" && fileName == "TimePoints.csv")
            {
                var GetTPoints = (SEPTA_DS.TimePointsTBLDataTable)tpta.GetDataByCategory(CategoryDDL.SelectedItem.ToString());

                //Loop through each row and insert into database
                int i = 0;
                foreach (DataRow row in TempRouteDataTable.Rows)
                {
                    //Gather column headers
                    var category = Convert.ToString(CategoryDDL.SelectedItem);
                    var agency = Convert.ToString(row["Agency"]);
                    if (agency == null || agency == "")
                    {
                        //If row is empty skip it entirely
                        goto skipped;
                    }
                    var route = Convert.ToString(row["Route"]);
                    var GetRShortName = (SEPTA_DS.RoutesTBLDataTable)rta.GetDataByRouteID(route);
                    var newRoute = "";
                    if (GetRShortName.Rows.Count > 0)
                    {
                        newRoute = Convert.ToString(GetRShortName.Rows[0]["route_short_name"]);
                    }

                    var direction = Convert.ToString(row["Direction"]);
                    var serviceKey = Convert.ToString(row["Service Key"]);
                    var language = Convert.ToString(row["Language"]);
                    var stopID = Convert.ToString(row["Stop ID"]);
                    var stopName = Convert.ToString(row["Stop Name"]);

                    if (stopName.Contains("accessible"))
                    {
                        string[] noHTML = stopName.Split('>');
                        int insertH = Convert.ToInt32(hta.InsertHandicapRow(newRoute,noHTML[2]));
                    }
                    var sequence = Convert.ToString(row["Sequence"]);
                    var origID = -1;

                    if (GetTPoints.Rows.Count > 0)
                    {
                        origID = Convert.ToInt32(GetTPoints.Rows[i]["TPointsID"]);
                        var GetID = (SEPTA_DS.TimePointsTBLDataTable)tpta.GetDataByID(origID);
                        if (GetID.Rows.Count < 1)
                        {
                            origID = -1;
                        }
                    }

                    if (origID == -1)
                    {
                        int insertData = Convert.ToInt32(tpta.InsertTimePoints(category, agency, newRoute, direction, serviceKey, language, stopID, stopName, sequence));
                    }
                    else
                    {
                        int updateData = Convert.ToInt32(tpta.UpdateTimePoints(category, agency, newRoute, direction, serviceKey, language, stopID, stopName, sequence, origID));
                    }
                    skipped:
                    i++;
                }
            }

You can see how I check whether to insert or update around the bottom. I am using this method across other sections of this program and it works just fine. But in this case it is distorting my datatable immensely and I can't figure out why.

This is the bottom part of my table after inserting [no items currently within the database]:

alt text

This is the table after reuploading the CSV with data already existing within the table:

alt text

I am also getting this error when updating There is no row at position 2230. What is going wrong in the code to cause this huge shift? I am just checking to see if the ID exists and if it does update rather than insert.

Also the reason i am using goto is because there are blank rows in the document that need to be skipped.

Upvotes: 0

Views: 113

Answers (1)

Siva Gopal
Siva Gopal

Reputation: 3502

Is your TPointsID column, a auto-generated number? If so, since you are skipping the empty row, some referential integrity problem might be occuring,because of empty data in the skipped rows in the database.

From the error : There is no row at position 2230 , it is also understood that, because of the skipping you might be trying to access some non existent row in the datatable.

Also, if possible consider using the ADO.NET DataAdapter which has got the CRUD operation capability. You can find more about it at : http://support.microsoft.com/kb/308507

Upvotes: 1

Related Questions