CODEWITHSUNDEEP
javascriptnode.jsexpress
Ammar Hayder Khan
Ammar Hayder Khan

Reputation: 1335

Node Js routing not working

I am trying to create an api in nodejs.

My server.js file is following

var http = require('http'),
    path = require('path'),
    async = require('async'), 
    socketio = require('socket.io'), 
    express = require('express'), 
    session = require('express-session'),
    logger = require('morgan'),
    bodyParser = require('body-parser');    

var app = express();
var server = http.createServer(app);
var io = socketio.listen(server);
  app.use(logger('dev'));
  app.use(bodyParser.json());

  app.all('/*', function(req, res, next) {
    // CORS headers
    res.header("Access-Control-Allow-Origin", "*"); // restrict it to the required domain
    res.header('Access-Control-Allow-Methods', 'GET,PUT,POST,DELETE,OPTIONS');
    // Set custom headers for CORS
    res.header('Access-Control-Allow-Headers', 'Content-type,Accept,X-Access-Token,X-Key');
    if (req.method == 'OPTIONS') {
      res.status(200).end();
    } else {
      next();
    }
  });
  app.all('/api/*', [require('./middlewares/validateRequest')]); 
  //app.use(express.static(path.resolve(__dirname, 'client')));

  app.use('/', require('./routes'));

  // If no route is matched by now, it must be a 404
  app.use(function(req, res, next) {
    var err = new Error('Not Found');
    err.status = 404;
    next(err);
  });        

var messages = [];
var sockets = [];

......
server.listen(process.env.PORT || 3000, process.env.IP || "0.0.0.0", function(){
  var addr = server.address();
  console.log("Meeting Panel listening at", addr.address + ":" + addr.port);
});

my /routes dir having index.js file

var express = require('express');
var router = express.Router();

var auth = require('./auth.js');
var meetings = require('./meetings.js');
var user = require('./users.js');

/*
 * Routes that can be accessed by any one
 */
router.post( '/login', auth.login);


/*
 * Routes that can be accessed only by authenticated & authorized users
 */
router.get('/api/admin/users', user.getAll);
 .....
 .....

module.exports = router;

Now when i open the /login page then i get the following error

Error: Not Found
   at /home/ubuntu/workspace/server.js:46:15
   at Layer.handle [as handle_request] (/home/ubuntu/workspace/node_modules/express/lib/router/layer.js:95:5)
   at trim_prefix (/home/ubuntu/workspace/node_modules/express/lib/router/index.js:312:13)
   at /home/ubuntu/workspace/node_modules/express/lib/router/index.js:280:7
   at Function.process_params (/home/ubuntu/workspace/node_modules/express/lib/router/index.js:330:12)
   at next (/home/ubuntu/workspace/node_modules/express/lib/router/index.js:271:10)
   at /home/ubuntu/workspace/node_modules/express/lib/router/index.js:618:15
   at next (/home/ubuntu/workspace/node_modules/express/lib/router/index.js:256:14)
   at Function.handle (/home/ubuntu/workspace/node_modules/express/lib/router/index.js:176:3)
   at router (/home/ubuntu/workspace/node_modules/express/lib/router/index.js:46:12)

Upvotes: 0

Views: 1356

Answers (2)

kailniris
kailniris

Reputation: 9496

If you just open the http://example/login in your browser it will be a get request so in this case it won't find the route cuz you are listening for post /login not get /login.

Upvotes: 1

MayaLekova
MayaLekova

Reputation: 550

Your route on /login is defined on the POST method. If you want to open it from browser (which I assume is what you're doing), you should define router.get( '/login'.... I guess you don't want to have a /login route defined on the GET method, so your other good option for testing is to hit /api/admin/users.

Upvotes: 1

Related Questions