CODEWITHSUNDEEP
c#wpfmultithreadingc#-4.0
Patrick Desjardins
Patrick Desjardins

Reputation: 140993

How to execute code in the GUI Thread?

I have a FileSystemWatcher that react on the Changed event.

I want to open the file, read its content display it in a textbox and hide the popup that has been created after 1 sec. The code almost work but something fail when hiding the popup.

Here is a snippet of the code :

       txtLog.Dispatcher.Invoke(DispatcherPriority.Normal, (Action)delegate() {
            this.txtLog.Text = dataToDisplay;
            extendedNotifyIcon_OnShowWindow();
            Thread threadToClosePopup = new Thread(new ThreadStart((Action)delegate() { 
                Thread.Sleep(1000); 

                extendedNotifyIcon_OnHideWindow();
       }));
            threadToClosePopup.Start();
        });

As you can see, I use the Invoke to set the text because the event is in a different thread (FileSystemWatcher). But to hide the windows the extendedNotifyIcon_OnHideWindow() is not executed in the thread of the GUI. How can I execute it in the GUI thread?

Upvotes: 11

Views: 40097

Answers (6)

Contango
Contango

Reputation: 80372

This works well for WPF with MVVM.

Application.Current.Dispatcher.Invoke(
    () =>
    {
         // Code to run on the GUI thread.
    });

This will not work consistently (it will fail if we are inside a handler for Reactive Extensions):

Dispatcher.CurrentDispatcher.Invoke(
    () =>
    {
         // Fails if we are inside a handler for Reactive Extensions!
    });

Extra for Experts: The Reason?

By design, any thread can have a dispatcher thread paired with it, see MSDN: Dispatcher Class.

If we reference Dispatcher.CurrentDispatcher from any thread, it will actually create a new dispatcher thread, which is separate to the official WPF UI dispatcher thread. When we try to execute code on this newly created dispatcher thread, WPF will throw as it's not the official UI dispatcher thread.

The solution is to always use Application.Current.Dispatcher.Invoke(), or Application.Current.Dispatcher.BeginInvoke(). See What's the difference between Invoke() and BeginInvoke().

Update 2020-05-02: It is possible to run a WPF application with multiple WPF UI dispatcher threads. I work with a huge WPF app that is doing this. It is tricky to get it to work, but once it works - it's amazing and the entire app runs an order of magnitude faster as there are multiple UI dispatcher threads. Happy to answer questions on this.

Tested on:

  • WPF
  • .NET 4.5
  • .NET 4.6
  • .NET 4.61

Upvotes: 36

Brian Gideon
Brian Gideon

Reputation: 48959

The problem is that extendedNotifyIcon_OnHideWindow is being executed on a thread other than the UI thread. You will need to use the Dispatcher for that part as well. Also, I would not create a dedicated thread just to wait one second. You could easily refactor that part into a System.Threading.Timer. Here is my refactored version.

txtLog.Dispatcher.Invoke(
    (Action)(() =>
        {
            txtLog.Text = dataToDisplay;
            extendedNotifyIcon_OnShowWindow(); 
            new Timer(
                (state) =>
                {
                    button1.Dispatcher.BeginInvoke(
                        (Action)(() =>
                            {
                              extendedNotifyIcon_OnHideWindow(); 
                            }), null);
                }, null, 1000, Timeout.Infinite);
        }));

Upvotes: 0

bitbonk
bitbonk

Reputation: 49649

Just wrap extendedNotifyIcon_OnHideWindow(); into a Dispatcher.Invoke()

But I would rather do it (all im XAML) using an Animation and with an EvenTrigger that triggers upon the TimeLine.Completed event.

Upvotes: 1

JaredPar
JaredPar

Reputation: 755397

To execute the extendedNotifyIcon_OnHideWindow method on the GUI thread use the Dispatcher as you did to show it. 

Thread threadToClosePopup = new Thread(new ThreadStart((Action)delegate() { 
  Thread.Sleep(1000); 
  txtLog.Dispatcher.Invoke(
    DispatcherPriority.Normal,
    (Action)() => extendedNotifyIcon_OnHideWindow());
}));

Upvotes: 11

Alex Reitbort
Alex Reitbort

Reputation: 13706

Use Control.Invoke

   txtLog.Dispatcher.Invoke(DispatcherPriority.Normal, (Action)delegate() {
        this.txtLog.Text = dataToDisplay;
        extendedNotifyIcon_OnShowWindow();
        Thread threadToClosePopup = new Thread(new ThreadStart((Action)delegate() { 
            Thread.Sleep(1000); 

            extendedNotifyIcon.Invoke(extendedNotifyIcon_OnHideWindow);
   }));
        threadToClosePopup.Start();
    });

Upvotes: 2

ozczecho
ozczecho

Reputation: 8859

This will give you the Window dispatcher:

Dispatcher.CurrentDispatcher

As long as you get it on the windows thread.

Upvotes: 4

Related Questions