CODEWITHSUNDEEP
javascriptinheritanceprototype
wheresrhys
wheresrhys

Reputation: 23500

Properties attaching to wrong object

I've adapted the Crockford object() function so that I can pass in some parameters and autorun an init function in the new object:

function object(o) {
    function F() {}
    F.prototype = o;
    var params = Array.prototype.slice.call(arguments,1);
    var obj = new F();
    if(params.length) {
     obj.init.apply(obj,params);
    }
    return obj;
}

This works fine most of the time, but within one object I have functions defined as follows:

MY.Object = function() {

 function init(element, generator) {
  build(element);
                // more code after
 }

 function build(element) {
  this._property = "example";
 }
     return {
        init: init;
     }
}();

If I then run

My.Object2 = object(MY.Object, "test param");

For some reason _property gets added to the Windows object. This stops if I make build a public method and call it using this.build().

Can anyone explain why this happens?

Upvotes: 1

Views: 71

Answers (1)

palswim
palswim

Reputation: 12140

build, although you've defined it within your class, has no context when you're calling it. So, no context means that this references your window object (within a browser, at least). But, even though you don't have the proper this context, you can still access your variables you've declared within the "private" scope of your class.

Try using build.call(this, element) (function.call is similar to function.apply).

Just know that JavaScript doesn't quite behave the same way as other OO languages you may have used, and that classes, and the notion of private and public (among other language features) are a bit of a hack.

Upvotes: 2

Related Questions