CODEWITHSUNDEEP
c#if-statement
New Start
New Start

Reputation: 1421

Why won't my simple if statement work?

I've designed a simple card game where two cards are displayed and the user has to bet on whether they will get a card that is in between the two cards displayed. If the user doesn't want to bet, they just deal again. The user begins with £100.

The game works fine in most aspects, but has a huge flaw. The user can bet more than they have in their balance. So, if the user has £100, they bet £105, and they win, they will have £205 in their balance. This is clearly bad! And if they have £100, they bet £105 and they lose, their balance stays the same. This is also pretty bad.
So I thought a simple if-statement would sort this out:

if (wager > balance)
{
    winLoseLabel.Text = "You can't bet more than you have!";
}  
switch (betResult)
{
    case TIE:
        winloseLabel.Text = "Tie. You still lose. HA!";
        myRules.Balance -= wager;
        break;

    case PLAYERWINS:    
        winloseLabel.Text = "You win. Woop-de-do..";
        myRules.Balance += wager;
        break;

    case DEALERWINS:
        winloseLabel.Text = "You lose. Get over it.";
        myRules.Balance -= wager;
        break;
}

Why doesn't this work? I'm pretty sure it's something so simple, but I'm pretty new to C#, so go easy on me!

Upvotes: 6

Views: 971

Answers (4)

Serkan Hekimoglu
Serkan Hekimoglu

Reputation: 4284

I dont understand exactly, but try

if (wager > balance)
{
    winLoseLabel.Text = "You can't bet more than you have!";
    return;
}

or

if (wager <= balance)
{
    switch (betResult)
    {
        case TIE:
            winloseLabel.Text = "Tie. You still lose. HA!";
            myRules.Balance -= wager;
            break;

        case PLAYERWINS:    
            winloseLabel.Text = "You win. Woop-de-do..";
            myRules.Balance += wager;
            break;

        case DEALERWINS:
            winloseLabel.Text = "You lose. Get over it.";
            myRules.Balance -= wager;
            break;
    }
}

Upvotes: 2

Christian Watteng&#229;rd
Christian Watteng&#229;rd

Reputation: 5681

Your if-statement is correct, however, you do not end the routine if it's triggered.

You can do this by adding a "return;" statement after setting the label, or, if you are depending on code underneath what you are showing us, you can include the switch-statement in the "else" part of the if-statement...

Upvotes: 3

Iain Ward
Iain Ward

Reputation: 9946

After your if statement you go into the case statement anyway, shouldn't you have an else around the case statement/?

Upvotes: 2

Dan Dumitru
Dan Dumitru

Reputation: 5333

You should have an else there:

if (wager > balance)
{
    winLoseLabel.Text = "You can't bet more than you have!";
}
else
{  
    switch (betResult)
    {
        //...
    }
}

Upvotes: 13

Related Questions