CODEWITHSUNDEEP
iphoneobjective-cnstimerdeallocinvalidation
Daniel Klöck
Daniel Klöck

Reputation: 21137

NSTimer not stopping

I have a Class with a NSTimer *myTimer; variable. At some point I do: 

myTimer = [NSTimer scheduledTimerWithTimeInterval:20 target:self selector:@selector(doStuff) userInfo:nil repeats: YES];

further, I have a method:

- (void)doStuff
{
  if(myTimer)
  {
    //do stuff
  }
}

and I stop my timer when the class is released through:

- (void)dealloc
{ 
 if (myTimer) { //if myTimer==nil it already has been stopped in the same way
  [myTimer invalidate];
  myTimer = nil;
 }
}

Now, the problem is that when I release the class the timer goes on and on and on firing the event anyway. Am I doing something wrong? It seems the dealloc method is never called, otherwise myTimer would be nil and even if the selector is fired it would not go into the if(myTimer)

Upvotes: 2

Views: 1111

Answers (2)

Joshua Nozzi
Joshua Nozzi

Reputation: 61228

Have you tried the handy debugger tools at your disposal? What happens if you set a breakpoint in your dealloc method? Also, you should post more context around your creation. Is it possible you're creating the timer more than once, thereby replacing the original (but not invalidating it) and leaving it out there to fire at will?

Upvotes: 0

Dave DeLong
Dave DeLong

Reputation: 243156

This will never work, because timers retain their target, which means your dealloc method will never get invoked until after you've invalidated the timer.

For more info, see the NSTimer documentation and this blog post on "Dangerous Cocoa Calls"

Upvotes: 7

Related Questions