CODEWITHSUNDEEP
concurrency
user123454321
user123454321

Reputation: 1058

ConcurrentHashMap put

I have a following map

ConcurrentMap<K, V> myMap = new ConcurrentHashMap<>();

and now I would like to insert new object into that map atomically, so I can do something like

V myMethod(K key, int val) {
    return map.putIfAbsent(key, new V(val));
}

but it is not atomic, because firstly new V will be created and then inserted into map. Is there any way to do this without using synchronized (or using synchronized is the fastest way here)?

Upvotes: 0

Views: 318

Answers (3)

user207421
user207421

Reputation: 310985

The Javadoc explicitly states that putIfAbsent() is atomic.

Upvotes: 0

Peter Lawrey
Peter Lawrey

Reputation: 533660

It appears you are looking for computeIfAbsent in Java 8.

V myMethod(K key, int val) {
    return map.computeIfAbsent(key, () -> new V(val));
}

This will only create a V object once per key. Note: it will still create a lambda object each time (unless Escape Analysis places it on the stack)

Upvotes: 0

EpicPandaForce
EpicPandaForce

Reputation: 81568

But... ConcurrentHashMap already uses synchronized internally.

/*
 * ORACLE PROPRIETARY/CONFIDENTIAL. Use is subject to license terms.
 * Written by Doug Lea with assistance from members of JCP JSR-166
 * Expert Group and released to the public domain, as explained at
 * http://creativecommons.org/publicdomain/zero/1.0/
 */

/** Implementation for put and putIfAbsent */
final V putVal(K key, V value, boolean onlyIfAbsent) {
    if (key == null || value == null) throw new NullPointerException();
    int hash = spread(key.hashCode());
    int binCount = 0;
    for (Node<K,V>[] tab = table;;) {
        Node<K,V> f; int n, i, fh;
        if (tab == null || (n = tab.length) == 0)
            tab = initTable();
        else if ((f = tabAt(tab, i = (n - 1) & hash)) == null) {
            if (casTabAt(tab, i, null,
                         new Node<K,V>(hash, key, value, null)))
                break;                   // no lock when adding to empty bin
        }
        else if ((fh = f.hash) == MOVED)
            tab = helpTransfer(tab, f);
        else {
            V oldVal = null;
            synchronized (f) {
                if (tabAt(tab, i) == f) {
                    if (fh >= 0) {
                        binCount = 1;
                        for (Node<K,V> e = f;; ++binCount) {
                            K ek;
                            if (e.hash == hash &&
                                ((ek = e.key) == key ||
                                 (ek != null && key.equals(ek)))) {
                                oldVal = e.val;
                                if (!onlyIfAbsent)
                                    e.val = value;
                                break;
                            }
                            Node<K,V> pred = e;
                            if ((e = e.next) == null) {
                                pred.next = new Node<K,V>(hash, key,
                                                          value, null);
                                break;
                            }
                        }
                    }
                    else if (f instanceof TreeBin) {
                        Node<K,V> p;
                        binCount = 2;
                        if ((p = ((TreeBin<K,V>)f).putTreeVal(hash, key,
                                                       value)) != null) {
                            oldVal = p.val;
                            if (!onlyIfAbsent)
                                p.val = value;
                        }
                    }
                }
            }
            if (binCount != 0) {
                if (binCount >= TREEIFY_THRESHOLD)
                    treeifyBin(tab, i);
                if (oldVal != null)
                    return oldVal;
                break;
            }
        }
    }
    addCount(1L, binCount);
    return null;
}

And

 * Insertion (via put or its variants) of the first node in an
 * empty bin is performed by just CASing it to the bin.  This is
 * by far the most common case for put operations under most
 * key/hash distributions.  Other update operations (insert,
 * delete, and replace) require locks.  We do not want to waste
 * the space required to associate a distinct lock object with
 * each bin, so instead use the first node of a bin list itself as
 * a lock. Locking support for these locks relies on builtin
 * "synchronized" monitors.

You shouldn't need to specify synchronized yourself.

Upvotes: 1

Related Questions