CODEWITHSUNDEEP
c#.netasp.net-mvc-3pdfmodel-view-controller
Lahib
Lahib

Reputation: 1365

Issues when downloading PDF file from MVC application

I have created a function where a user can download a pdf file from my webpage. The file is stored in a databse and is requested from a webapi. The return value of the webapi is a byte[].

My issue here is that when i run the web application on my local iis this function runs without any errors. I get the pdf file and it is downloaded correctly on my machine. But when i deploy the web application to my Test server this code generates either RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION in chrome with some of the files where as other files are downloaded to the machine but when i try to open the pdf file i get: could not load the pdf file.

This happens with both chrome and IE.

This is my code:

[HttpGet]
[DoNotChangeCacheSettings]
public virtual FileResult DownloadTranslationFile(Guid id)
{
    Guid assessmentTemplateId = id;
    File translationFile = Services.GetFileContent(assessmentTemplateId);
    var fileName = HttpUtility.UrlPathEncode(translationFile.FileName);
    this.HttpContext.Response.Headers.Add("Content-Disposition", "attachment; filename=\"" + fileName + "\"");
    var result = File(translationFile.FileContent.Content, System.Net.Mime.MediaTypeNames.Application.Pdf, fileName);
    return result;
}

I have been trying to fix this issue for 2 days now but i simply cant figure out what the issue is. Hope you guys can help. Thanks.

Upvotes: 1

Views: 3654

Answers (1)

smoksnes
smoksnes

Reputation: 10851

You don't need to use Content-Disposition. .Net will add it for you. From the docs.

The fileDownloadName parameter is used to generate the content-disposition header. The result object that is prepared by this method is written to the response by the ASP.NET MVC framework when the object is executed. The MediaTypeNames class can be used to get the MIME type for a specific file name extension.

I tend to use the Stream-overload:

[HttpGet]
[DoNotChangeCacheSettings]
public virtual FileResult DownloadTranslationFile(Guid id)
{
    Guid assessmentTemplateId = id;
    File translationFile = Services.GetFileContent(assessmentTemplateId);
    var fileName = HttpUtility.UrlPathEncode(translationFile.FileName);
    var stream =  = new MemoryStream(translationFile.FileContent.Content);
    return File(stream, "application/pdf", fileName);
}

But you can use the byte[] as well:

[HttpGet]
[DoNotChangeCacheSettings]
public virtual FileResult DownloadTranslationFile(Guid id)
{
    Guid assessmentTemplateId = id;
    File translationFile = Services.GetFileContent(assessmentTemplateId);
    var fileName = HttpUtility.UrlPathEncode(translationFile.FileName);
    return File(translationFile.FileContent.Content, "application/pdf", fileName);
}

EDIT: If you got an error when opening the PDF you can ensure that the web browser is doing the right thing by manually saving the PDF from code as well. If that file has errors as well you're probably generating an incorrect byte[].

[HttpGet]
[DoNotChangeCacheSettings]
public virtual FileResult DownloadTranslationFile(Guid id)
{
    Guid assessmentTemplateId = id;
    File translationFile = Services.GetFileContent(assessmentTemplateId);
    var fileName = HttpUtility.UrlPathEncode(translationFile.FileName);
    var stream =  = new MemoryStream(translationFile.FileContent.Content);

    // Code for debugging
    var tempDir = "C:\\temp"; // Make sure app pool can write here.
    var path = Path.Combine(tempDir, fileName); // Possibly add extension here.
    using (var fileStream = File.Create(path))
    {
        stream.Seek(0, SeekOrigin.Begin);
        stream.CopyTo(fileStream);
    }
    stream.Seek(0, SeekOrigin.Begin);

    // Return to client.
    return File(stream, "application/pdf", fileName);
}

Upvotes: 2

Related Questions