How to exit the loop with the number 0? but now i have other problems

Question

package hw3;

public class Main {
    public static void main(String[] args) {
        final int NumberOfElements = 1000;
        int[] num = new int[NumberOfElements];
        int var = 0;
        //create input
        java.util.Scanner input = new java.util.Scanner(System.in);
        for (int i = 0; i < NumberOfElements; i++) {
            System.out.print("Enter any positive number or enter 0 to stop: ");
            num[i] = input.nextInt();
            var++; 
            if (num[i] == 0)

                break;

            }
             Arrays.sort( num, 0, var);
             int i;
             for (i = 0; i < var; i++) {
             System.out.print("   " + num[i]);


        }
    }
}

Write a Java program reading a sequence of positive integers entered one per line. The program stops reading when integer ‘0’ is entered. The program will sort and output them into an ascending numerical order.For example: 5 1 7 12 36 8 0 Output: 1 5 7 8 12 36

Answer 1

Try to understand the problem: there are three steps.
Step 1: Get the input from the user. Continue getting input till the user enters 0
Step 2: Sort
Step 3: Print out the results

Step 1: Your for loop is almost correct.
But the for loop should end immediately after you have got the input.
In the following code,

   num[i] = input.nextInt();
   var++; 
   if (num[i] == 0)
      break;

you are adding the user input to the array and then checking whether it is 0. This means that the 0 will also be part of your array. If you don't want this, you should check the input and add it to the array only if it is not 0.

Also note the declaration of i before the for loop. Because we need it after the for loop. Why? see below.

int i = 0; 
for (i = 0; i < NumberOfElements; i++) {
   int n = input.nextInt();
    if (n == 0)
       break;
    else
       num[i] = n;
} //for loop ends here

Step 2: Sort it
Arrays.sort(num);

Step 3: Print the output:

for (i = 0; i < num.length; i++) {
      System.out.print("  " + num[i]);
   }

The problem is, in step 2, an array of 1000 elements is sorted, while you actually need to consider only the number of elements the user has entered. You don't know that initially thats why you created an array of 1000 elements.But, at this point (after step 2) you do know how many number of elements the user has entered. This is present in i

So new step between 1 and 2: Create a new arrays that contains only those elements that the user has entered.
Step 1.5:

int[] newArray = Arrays.copyOf(num, i);

Now sort this new array, and print it (same as your code, but uses the new array we just created)

Arrays.sort(newArray);

for (i = 0; i < newArray.length; i++) {
      System.out.print("  " + newArray[i]);
   }

Notes:
1. The ideal way to do this is to use Lists and not arrays, but probably since this is homework, you might have to use arrays.

1. Since this is homework, I don't know whether you are allowed to use Arrays.sort or Arrays.copy. Your professor might frown at this because perhaps his intention was that you learn the constructs of the language via for, if and while. In that case you have to do step 1.5 (make array the right size) and sort by yourself.
   This is not difficult (but just remember this is not the best way to do it, except for in a homework)

Copy array (homemade) (in place of step 1.4 above)

int[] newArray = new int[i]
for(int j=0; j<i; j++){
   newArray[j] = num[j];
}

Sort (homemade) (in place of step 2 above):

1. Loop through the elements
2. If one element is greater than the previous element, swap them (in asc order, the prev element is always lesser or equal to the next element)

There are two loops because you have to do the comparison on a continuous basis: the the first element, compare with the entire array, place it in the right position, take the second compare with the entire array etc...)

  for(int j=0; j<newArray.length; j++) {
      for(int k=0; k<newArray.length; k++) {
         if(newArray[k] > newArray[j]) { 
            //the swap logic:
            int t = newArray[k];
            newArray[k] = newArray[j];
            newArray[j] = t;
         }
      }
   }

Try to understand what really is happening, instead of just copy pasting. Once you understand the homemade sort logic, think about this: The second for loop in the sort or(int k=0; k<newArray.length; k++) { can actually just be for(int k=0; k<newArray.length; k++) {. Why?

Your print loop will remain the way you wrote it, but you will print newArray rather than num. You might want to change the loop variable to int j or something, but i will also work. (i holds the no of inputs now, so I would not use it for any other purpose. But it is just a manner of coding. Technically no difference - the code will work the same way)

I am not combining the parts. I leave that o you, otherwise it will look like I did your homework :-)

Answer 2

Here your application is reading int, you can check that the last one is != from 0. And break the loop.
If you don't like using break, you can still add a condition to your for.

For sorting an array, there is the Arrays.sort() solution.

And to print them you'll need another loop, but beware as you can have less than 1000 items in your array you can't simply print the whole array.
You'll need to find a way to count the number of elements you added in the array.

---

After your edit:

Good your application seems to work here is what I got :

Mac-Makkhdyn:~ Makkhdyn$ java hw3.Main
Enter any positive number or enter 0 to stop: 1
Enter any positive number or enter 0 to stop: 2
Enter any positive number or enter 0 to stop: 3
Enter any positive number or enter 0 to stop: 4
Enter any positive number or enter 0 to stop: 5
Enter any positive number or enter 0 to stop: 0
Mac-Makkhdyn:~ Makkhdyn$

The 0 you have must be from somewhere else. Isn't your actual code slightly different from the one you posted here ?

---

Resources :

• javadoc - Arrays.sort()
• Java tutorial - The break Statement

Answer 3

num[i] holds the last number you are reading. So you have to compare it against 0 and if it is 0, you have to end the loop. Read about branching statements to find out how to do that.

It is probably also good for you to read about control flow statements in general.