CODEWITHSUNDEEP
swiftswifty-jsonforced-unwrapping
user2636197
user2636197

Reputation: 4122

Swift safely unwrapping optinal strings and ints

When I am about to fire my segue for the 2nd view I also send some values like this:

if let aTime = ads[indexPath.row]["unix_t"].int {
    toView.time = aTime
}

if let aTitle = ads[indexPath.row]["title"].string {
    toView.title = aTitle
}

In the second VC I have declared the varibles like:

var time: Int?
var title: String?

and this is how I unwrap the values:

if time != nil {
   timeLabel.text = String(time!)
}

if title != nil {
   titleLabel.text = title!
}

This all works I never get any error caused by unwrapped varibles or nil values. But is there any easier way to do it?

Right now it feels like I am checking too much

Upvotes: 8

Views: 12325

Answers (5)

ranjit.x.singh
ranjit.x.singh

Reputation: 307

You don't need to check nil condition in the first view. Please follow below code:

toView.time = ads[indexPath.row]["unix_t"] as? Int

toView.title = ads[indexPath.row]["title"] as? String

time and title variable in second view are optionals. So, when you assign a value to toView.time and toView.title, it will either assign the value of type time and title respectively or nil.

Upvotes: 1

vadian
vadian

Reputation: 285250

Yes, you are checking too much (twice).

Since only non-optional values are passed you can declare the variables non-optional

var time = 0
var title = ""

and set the labels

timeLabel.text = "\(time)"
titleLabel.text = title

The strong type system of Swift highly recommends first to consider

Can I accomplish this without optionals?

and – if there is no other option – then use optionals.

Upvotes: 1

Mtoklitz113
Mtoklitz113

Reputation: 3878

You can use the Nil Coalescing Operator too as given in the Docs:

The nil coalescing operator (a ?? b) unwraps an optional a if it contains a value, or returns a default value b if a is nil. The expression a is always of an optional type. The expression b must match the type that is stored inside a.

The nil coalescing operator is shorthand for the code below:

a != nil ? a! : b

Upvotes: 8

keithbhunter
keithbhunter

Reputation: 12334

I can think of three alternatives.

  1. if/let. Very similar to your current option, but you don't have to implicitly unwrap.

    if let time = time {
    timeLabel.text = "\(time)"
}

if let title = title {
    titleLabel.text = title
}

    You can even unwrap them on the same line. The downside to this is that if one of them is nil, then neither label will be set.

    if let time = time, let title = title {
    timeLabel.text = "\(time)"
    titleLabel.text = title
}

  2. guard/let. If these are in a function like setupViews(), then you can one-line your unwrapping like so:

    func setupViews() {
    guard let time = time, let title = title else { return }
    timeLabel.text = "\(time)"
    titleLabel.text = title
}

  3. You can use default values and the ?? operator to unwrap quickly.

    timeLabel.text = "\(time ?? 0)"
titleLabel.text = title ?? ""

Upvotes: 12

Kametrixom
Kametrixom

Reputation: 14983

if let time = time {
    timeLabel.text = "\(time)"
}

if let title = title {
    titleLabel.text = title
}

It's the same as with your JSON

Upvotes: 2

Related Questions