CODEWITHSUNDEEP
phpjson
Mehr
Mehr

Reputation: 5

PHP doesn't return json decode

I have been trying to fetch some data from steam API which returns JSON such as this: 

{"success":true,"lowest_price":"$2.76","volume":"345","median_price":"$2.60"}

However it does not return anything to the variable which is used somewhere else. It just shows 0.

Here's my JSON code, what am I doing wrong?

$steam1 = "http://steamcommunity.com/market/priceoverview/?currency=1&appid=730&market_hash_name=Chroma%20Case%20Key";
$json = file_get_contents($steam1);
$json_data = json_decode($json, true);
$median1= $json_data["median_price"];
$media1 = $median1 / '2.49';

Thanks for any help anyone can offer.

Upvotes: 0

Views: 62

Answers (3)

RiggsFolly
RiggsFolly

Reputation: 94642

There is a dollar in the $json_data["median_price"] so that must be removed before you can use the field in any arithmetic.

Also you need to use a number as a divisor and not a string.

This works

<?php
$steam1 = "http://steamcommunity.com/market/priceoverview/?currency=1&appid=730&market_hash_name=Chroma%20Case%20Key";
$json = file_get_contents($steam1);
$json_data = json_decode($json, true);
$median1= $json_data["median_price"];
$median1 = substr($median1,0,1) == '$' ? substr($median1,1) : $median1;  //remove the $
$media1 = $median1 / 2.49;
echo $media1;

Upvotes: 1

Leonid Zakharov
Leonid Zakharov

Reputation: 970

=)) I hope you joke!

// It's ok:
$steam1 = "http://steamcommunity.com/market/priceoverview/?currency=1&appid=730&market_hash_name=Chroma%20Case%20Key";
$json = file_get_contents($steam1);
$json_data = json_decode($json, true);

// here you set $median1 = "$2.60", yeah, it's string (not float number)
$median1= $json_data["median_price"];

// here you trying to divide one string to another
$media1 = $median1 / '2.49';

It's very interesting way )))

Change last string to:

if (preg_match('/([0-9]+(?:\.[0-9]+))/', $median1, $matches)) {
    $media1 = round($matches[1] / 2.49, 2);
} else {
    $media1 = 0;
}
echo $media1 . "\n";

Good luck!

Upvotes: 1

Barmar
Barmar

Reputation: 780663

json_decode() is working fine. The problem is that you can't do arithmetic when a number begins with $.

You need to remove the $ character at the beginning of the price before you can use it as a number. Otherwise, it will be converted to 0.

$median1 = ltrim($json_data["median_price"], '$');
$media1 = $median1 / 2.49;

Upvotes: 3

Related Questions