CODEWITHSUNDEEP
javascriptnode.jsasynchronousmeteorasync.js
b24
b24

Reputation: 2473

using Async in Meteor 1.3+

Hi guys I want to use Async NPM package and eachLimit function in Meteor 1.3+ I used it later without Meteor like below and it's worked well:

var items = ["test", "test2","test3","test4","test5","test6","test7","test8","test9","test10","test11","test12","test13","test14","test15","test16","test17","test18","test19","test20"];
async.eachLimit(items, 5, (item, callback) => {
                        try {
                            //console.log(item);
                            heavyProcess(item);
                        }
                        catch (e) {
                            return callback(e);
                        }
                        callback();
                    }, (err) => {
                        if (err) console.error(err.message);
                    });
function heavyProcess(item) {
setTimeout(function () {
            console.log(item);
        }, Math.floor(Math.random() * 10000));
}

You can see this here: https://jsfiddle.net/g0L90f3h/

This is above code output:

test3
test8
test18
test5
test20
test15
test19
test
test9
test11
test14
test17
test2
test12
test4
test10
test13
test7
test16
test6

Above output is correct perfectly. Now I migrate above code to Meteor like below:

// startup.js
import async from 'async';
let items = ["test", "test2","test3","test4","test5","test6","test7","test8","test9","test10","test11","test12","test13","test14","test15","test16","test17","test18","test19","test20"];
            async.eachLimit(items, 5, (item, callback) => {
                try {
                    my_utils.heavyProcessSimulator(item);
                }
                catch (e) {
                    return callback(e);
                }
                callback();
            }, (err) => {
                if (err) console.error(err.message);
            });

// my_utils.js
    heavyProcessSimulator(item) {
        Meteor._sleepForMs(Math.floor(Math.random() * 10000));
        console.log(item);
    }

But it's return below output that is wrong:

I20160802-18:25:07.959(4.5)? test
I20160802-18:25:15.477(4.5)? test2
I20160802-18:25:20.915(4.5)? test3
I20160802-18:25:28.284(4.5)? test4
I20160802-18:25:31.842(4.5)? test5
I20160802-18:25:35.694(4.5)? test6
I20160802-18:25:38.871(4.5)? test7
I20160802-18:25:48.812(4.5)? test8
I20160802-18:25:52.452(4.5)? test9
I20160802-18:25:58.944(4.5)? test10
I20160802-18:26:06.411(4.5)? test11
I20160802-18:26:08.461(4.5)? test12
I20160802-18:26:09.135(4.5)? test13
I20160802-18:26:17.474(4.5)? test14
I20160802-18:26:24.613(4.5)? test15
I20160802-18:26:31.605(4.5)? test16
I20160802-18:26:34.022(4.5)? test17
I20160802-18:26:36.792(4.5)? test18
I20160802-18:26:39.646(4.5)? test19
I20160802-18:26:41.706(4.5)? test20

Why this happens and how to fix this? I test many things but not found issue. Why it's run sync?

Edit:

Many thanks for @hwillson for awesome answers I change my code like below but still output is wrong. This is my new code:

import async from 'async';
const items = ["test", "test2", "test3", "test4", "test5", "test6", "test7", "test8", "test9", "test10", "test11", "test12", "test13", "test14", "test15", "test16", "test17", "test18", "test19", "test20"];

        async function heavyProcessSimulator(item) {
            console.log("Process Start for: " + item);
            Meteor._sleepForMs(Math.floor(Math.random() * 10000));
            console.log("Process Finished for: " + item);
        }

        async.eachLimit(items, 5, (item, callback) => {
            try {
                heavyProcessSimulator(item);
            } catch (e) {
                return callback(e);
            }
            callback();
        }, (err) => {
            if (err) console.error(err.message);
        });

And this is output:

I20160805-13:45:00.014(4.5)? Process Start for: test
I20160805-13:45:00.014(4.5)? Process Start for: test2
I20160805-13:45:00.015(4.5)? Process Start for: test3
I20160805-13:45:00.015(4.5)? Process Start for: test4
I20160805-13:45:00.016(4.5)? Process Start for: test5
I20160805-13:45:00.016(4.5)? Process Start for: test6
I20160805-13:45:00.017(4.5)? Process Start for: test7
I20160805-13:45:00.017(4.5)? Process Start for: test8
I20160805-13:45:00.018(4.5)? Process Start for: test9
I20160805-13:45:00.023(4.5)? Process Start for: test10
I20160805-13:45:00.024(4.5)? Process Start for: test11
I20160805-13:45:00.024(4.5)? Process Start for: test12
I20160805-13:45:00.025(4.5)? Process Start for: test13
I20160805-13:45:00.025(4.5)? Process Start for: test14
I20160805-13:45:00.026(4.5)? Process Start for: test15
I20160805-13:45:00.026(4.5)? Process Start for: test16
I20160805-13:45:00.027(4.5)? Process Start for: test17
I20160805-13:45:00.027(4.5)? Process Start for: test18
I20160805-13:45:00.028(4.5)? Process Start for: test19
I20160805-13:45:00.029(4.5)? Process Start for: test20
I20160805-13:45:00.665(4.5)? Process Finished for: test19
I20160805-13:45:00.744(4.5)? Process Finished for: test2
I20160805-13:45:00.841(4.5)? Process Finished for: test
I20160805-13:45:00.917(4.5)? Process Finished for: test11
I20160805-13:45:02.438(4.5)? Process Finished for: test4
I20160805-13:45:02.953(4.5)? Process Finished for: test5
I20160805-13:45:04.727(4.5)? Process Finished for: test3
I20160805-13:45:05.510(4.5)? Process Finished for: test8
I20160805-13:45:05.562(4.5)? Process Finished for: test7
I20160805-13:45:05.849(4.5)? Process Finished for: test16
I20160805-13:45:06.231(4.5)? Process Finished for: test17
I20160805-13:45:06.527(4.5)? Process Finished for: test12
I20160805-13:45:06.959(4.5)? Process Finished for: test18
I20160805-13:45:07.147(4.5)? Process Finished for: test10
I20160805-13:45:07.313(4.5)? Process Finished for: test13
I20160805-13:45:08.027(4.5)? Process Finished for: test6
I20160805-13:45:08.736(4.5)? Process Finished for: test15
I20160805-13:45:08.912(4.5)? Process Finished for: test9
I20160805-13:45:08.962(4.5)? Process Finished for: test20
I20160805-13:45:08.975(4.5)? Process Finished for: test14

As you see above code work async now but still limit not correct. It call all 20 item first and then process.

Upvotes: 0

Views: 170

Answers (1)

hwillson
hwillson

Reputation: 1399

Meteor 1.3+ has built in async / await support (on both the client and server), thanks to the Meteor ecmascript package. You don't need to use a 3rd party package to run your code asynchronously. For example:

Server example: /server/main.js

import { Meteor } from 'meteor/meteor';

const items = [
  "test", "test2", "test3", "test4", "test5", "test6", "test7", "test8", 
  "test9", "test10", "test11", "test12", "test13", "test14", "test15", 
  "test16", "test17", "test18", "test19", "test20"
];

async function heavyProcessSimulator(item) {
  Meteor._sleepForMs(Math.floor(Math.random() * 10000));
  console.log(item);
}

items.forEach((item) => {
  heavyProcessSimulator(item);
});

Sample output:

I20160802-15:15:47.220(-4)? test16
I20160802-15:15:47.959(-4)? test9
I20160802-15:15:48.331(-4)? test18
I20160802-15:15:49.183(-4)? test7
I20160802-15:15:49.211(-4)? test13
I20160802-15:15:49.289(-4)? test14
I20160802-15:15:49.587(-4)? test
I20160802-15:15:49.776(-4)? test17
I20160802-15:15:51.195(-4)? test15
...

Client example: /client/main.js

const items = [
  "test", "test2", "test3", "test4", "test5", "test6", "test7", "test8",
  "test9", "test10", "test11", "test12", "test13", "test14", "test15",
  "test16", "test17", "test18", "test19", "test20"
];

async function heavyProcessSimulator(item) {
  setTimeout(() => {
    console.log(item);
  }, (Math.floor(Math.random() * 10000)));  
}

items.forEach((item) => {
  heavyProcessSimulator(item);
});

Sample output:

test16
test19
test14
test2
test3
test11
test9
test10
...

Just make sure you have the ecmascript package installed (it should be by default with Meteor 1.3+ projects, but just in-case: meteor add ecmascript).

You can combine Meteor's async support with features from the async npm package. Here's a revised example showing how to use async.eachLimit:

Server example: /server/main.js

import { Meteor } from 'meteor/meteor';
import async from 'async';

const items = [
  "test", "test2", "test3", "test4", "test5", "test6", "test7", "test8",
  "test9", "test10", "test11", "test12", "test13", "test14", "test15",
  "test16", "test17", "test18", "test19", "test20"
];

async function heavyProcessSimulator(item, callback) {
  Meteor._sleepForMs(Math.floor(Math.random() * 10000));
  console.log(item);
  callback();
}

async.eachLimit(items, 5, (item, callback) => {
  try {
    heavyProcessSimulator(item, callback);
  } catch (e) {
    return callback(e);
  }
}, (err) => {
  if (err) console.error(err.message);
});

Upvotes: 1

Related Questions