Ritz
Reputation: 1253
How to do code-review changes before submitting in Perforce?
Is there a way to get code-reviews done by PEER before submitting the changes in Perforce?I heard p4 shelve is an option,is it right?is there a better way?
p4 [g-opts] shelve [files ...]
Upvotes: 4
Views: 2372
Answers (1)
Samwise
Reputation: 71454
I would say that "p4 shelve" is the best way to do code review. You might want to look at Swarm, which offers code review features that are based around shelving.
https://www.perforce.com/perforce/r16.1/manuals/cmdref/p4_shelve.html https://www.perforce.com/perforce/r16.1/manuals/swarm/chapter.code_reviews.html
Upvotes: 4
Related Questions
- Is there any way to put gatekeeping in Perforce for code checkins?
- Perforce submit edited source file and branch/integrate/merge/copy from same source file in one changelist
- Perforce -Keep working on the project while the code is under review
- Perforce, can submitted changes be shelved?
- How to review and modfiy changes before submitting, using IntelliJ's perforce integration?
- Perforce - "rebase" a previous submission
- System for testing and submitting pending changes (ideally in Perforce)
- Perforce: Is there a straightforward way to track a code change to the original submission?
- Perforce Submit/Commit Condition
- Perforce doesn't know that I have changes to submit