CODEWITHSUNDEEP
javascriptreactjsreact-router
balu000
balu000

Reputation: 659

How to fetch data when a React component prop changes?

My TranslationDetail component is passed an id upon opening, and based on this an external api call is triggered in the class constructor, receiving data to the state, and this data being displayed on TranslationDetail.

//Routing:
<Route path="/translation/:id" component={TranslationDetail}/>

//Class:    
class TranslationDetail extends Component {
  constructor(props){
    super(props);

    this.props.fetchTrans(this.props.params.id);
  }

This all works fine if I enter the url manually. In case I'd like to use react-router e.g. for displaying the next item like below the url does change, but the api call is not triggered, and the data will remain the same.

<button 
  type="button"
  onClick={() => 
    browserHistory.push(`/translation/${Number(this.props.params.id)+1}`)}>
  Next
</button>

Please bear in mind that I'm a total beginner. The reason why this is happening is I believe that the constructor is run only once, thus no further api call is triggered.

How can I solve this? Do I need to listed to props and call a function on change? If yes, how?

Upvotes: 60

Views: 57103

Answers (4)

Yury Tarabanko
Yury Tarabanko

Reputation: 45106

Constructor is not a right place to make API calls.

You need to use lifecycle events:

Make sure to compare the props with the previous props in componentDidUpdate to avoid fetching if the specific prop you care about hasn't changed.

class TranslationDetail extends Component {    
   componentDidMount() {
     this.fetchTrans();
   }

   componentDidUpdate(prevProps) {
     if (prevProps.params.id !== this.props.params.id) {
       this.fetchTrans();
     }
   }

   fetchTrans() {
     this.props.fetchTrans(this.props.params.id);
   }
}

Upvotes: 114

Kevin
Kevin

Reputation: 961

From React 16.3 and onwards componentWillMount, componentWillUpdate and componentWillReceiveProps are deprecated.

You can use static getDerivedStateFromProps and return a new state based on changes on props.

You don't have access to your this objects like props, so you cannot compare nextProps with your current props by nextProps.sth !== this.props.sth. You can compare you prevState value with nextProps and return new value of state.

Make sue you add UNSAFE_ to your current componentWillMount and the other deprecated lifecyle methods for now.

Upvotes: 7

Carlos
Carlos

Reputation: 1431

I would use the render method. If the data is not loaded I would render a loader spinner and throw the action that fetch de data. For that i usually use the stores. Once the store has de data from the api, mark the data as loaded, throw an event and let the component get the data from the store, replacing the loader spinner with your data representation.

Upvotes: -1

JFAP
JFAP

Reputation: 3737

Use componentWillMount to get the data and set the state. Then use componentWillReceiveProps for capturing update on the props.

You can check the Component Specs and Lifecycle.

Upvotes: 0

Related Questions