CODEWITHSUNDEEP
javascriptjquerytwitter
salad_bar_breath
salad_bar_breath

Reputation: 281

Tweet button opening new window and new tab

I am doing FreeCodeCamp's Random Quote Machine exercise.

Using this answer, I tried to set up my tweet button to open up a new window rather than a tab that the user could use to Tweet this quotes with.

The only issue is is that it is opening up a new tab as well as a new window. Is there any way I could get it to just open the new window?

HTML for Tweet Link

<a class="twitter-share-button" href="https://twitter.com/intent/tweet" target="_newwin">
Tweet</a>

Related JavaScript

jQuery('a[target^="_newwin"]').click(function() {
    var width = 500;
    var height = 300;
    window.open(this.href , 'newwindow', 'width=' + width + ', height=' + height + ', top=' + ((window.innerHeight - height) / 2) + ', left=' + ((window.innerWidth - width) / 2));
});

Pen of my Project

Thank you!

Upvotes: 2

Views: 2098

Answers (1)

Martin
Martin

Reputation: 7714

You are getting both your custom behavior (opening a new window) and the standard behavior of a link (in most browser nowadays, opening a new tab). To prevent the latter, you need to use the ´preventDefault´ method:

jQuery('a[target^="_newwin"]').click(function(e) {
    e.preventDefault();
    var width = 500;
    var height = 300;
    window.open(this.href , 'newwindow', 'width=' + width + ', height=' + height + ', top=' + ((window.innerHeight - height) / 2) + ', left=' + ((window.innerWidth - width) / 2));
});

Upvotes: 4

Related Questions