CODEWITHSUNDEEP
javascriptphpsafari
Thomas Valadez
Thomas Valadez

Reputation: 1747

javascript not operating in safari

I have a funny issue. For some reason on Safari browser the javascript Logic Gates are not working properly. Here is a breakdown:

This whole script is being called with $(#id).load(my/script.php) function

I create a clean vairable.

$perm = $_POST['permission'].

I create html variable

$html_content .= " <div id='bsid_$account_id' onclick="bsview(id)"></div>

I echo the html 

<?=$html_content?>

Based on permission ai change the functionality of bsview function i applied in my div. 

if ("<?=$perm?>" != "user"){
  function bsview(id) {
    console.log('manager');
  } 
}else{
 function bsview(id) {
    console.log('user_view');
 }
}

Then something funny happens. After checking in Chrome, IE, and Firefox I confirm that the code is working. However when I run the code in Safari the logic gate that should return "TRUE" this permission doesn't equal 'user', instead returns FALSE. This is code echoed into my Safari debugging thinger. 

if ("manager" !== "user"){
  console.log('manager');

  function bsview(id) {
    console.log('manager');
  }

}else{
  function bsview(id) {
    console.log('user_view');

  }
}
</script>

And of course it console logs 'users_view'

Ok. If anyone has any insight or criticism for my crappy code please send them my way. I would love to know why this is happening, and how to avoid this same thing from happening.

Upvotes: 0

Views: 56

Answers (1)

Barmar
Barmar

Reputation: 780974

According to

Function declarations inside if/else statements?

it's not valid to put function declarations inside if/else. You should declare the function name outside the if, and then assign to it.

var bsview;
if ("<?=$perm?>" != "user"){
  bsview = function (id) {
    console.log('manager');
  } 
}else{
 bsview = function (id) {
    console.log('user_view');
 }
}

Or you could simplify it to:

function bsview(id) {
    console.log('<?= $perm == "user" ? 'user_view' : 'manager' ?>');
}

Upvotes: 2

Related Questions