CODEWITHSUNDEEP
javaregex
user4918296
user4918296

Reputation:

Java Pattern does not match RegEx

I have the following Java code that is supposed to extract a url from a String object

public static void main() {
    String text = "Link to https://some.domain.com/subfolder?sometext is     available";
    String regex = "https://some\\.domain\\.com/subfolder[^ ]*";
    Pattern urlPattern = Pattern.compile(regex);

    Matcher m = urlPattern.matcher(text);

    String url = m.group();

    System.out.println(url);

    return;
}

However, there is no match and the code fails with IllegalStateException.

What is wrong with the RegEx?

Upvotes: 2

Views: 2196

Answers (3)

AlexR
AlexR

Reputation: 115328

You forgot to call m.find() or m.matches(). This is mandatory, otherwise group() does not work.

The find() should return true if the pattern is matched. Only in this case group() will return what you are expecting.

So, modify your code as following:

....
if (!m.find()) {
    return;
}
String url = m.group();
...

EDIT Concerning to what method to call: find() or matches(). find() looks for the pattern in part of string, matches() matches full string. They relate like contains() and equals() of strings.

I personally prefer to use find() because in this case the regex fully defines the behavior. If I want to match full string I use ^ and $.

Upvotes: 3

fge
fge

Reputation: 121710

You can't ask a Matcher to give a .group() unless you have called a method which asks the Matcher to operate on the input: one of .find() (preferred), .lookingAt() or .matches().

This is why you get an IllegalStateException.

As to the differences between the three, while the javadoc tells it all, just a quick reminder:

  • .find() does "real" regex matching: it will try and match the regex anywhere in the input text;
  • .lookingAt() adds the constraint that the pattern should match at the beginning of the input text;
  • .matches() is a misnomer since in addition to the constraint imposed by .lookingAt(), it also required that the full input text (the "entire region" in the javadoc) is matched.

Please also recall that those three methods return a boolean depending on whether the match was successful; if the result is false, you can't .group().

Upvotes: 7

piet.t
piet.t

Reputation: 11911

Since m.group()

Returns the input subsequence matched by the previous match.

you have to call m.matches() or m.find() before using m.group().

Upvotes: 2

Related Questions