Android: Error when using Service for Background Task?

Question

I'm developing an Android application for downloading a file from server and save that file to the path specified..

I want to make this happen in the background, So I code the downloading function in service. Now I'm getting an error when I used the code in my service..

Can anyone help me to find the error... Thank You..

My Service code Is...

public class MyService extends Service {

  Contacts c = new Contacts();
  // File url to download
    private static String file_url = "http://f23.wapka-files.com/download/6/9/4/1408248_69459e029be95f96ff9f98ff.mp3/a0f9f2173d3d81a49c28/01-Podimeesha-Anand.Madhusoodhanan.mp3y";

    public MyService() {
    }

    @Override
    public IBinder onBind(Intent intent) {
        // TODO: Return the communication channel to the service.
        throw new UnsupportedOperationException("Not yet implemented");
    }
    @Override
    public int onStartCommand(Intent intent, int flags, int startId) {

            File folder = new File(Environment.getExternalStorageDirectory().getPath() + "/Jithin's/");
            if (!folder.exists()) {
                try {
                    folder.mkdirs();
                } catch (Exception e) {
                    e.printStackTrace();
                    System.out.println("Default Save Path Creation Error:" + folder);
                }
            }
            c.setA(Environment.getExternalStorageDirectory().toString() + "/Jithin's/downloadedfile.srt");
            // starting new Async Task
            new DownloadFileFromURL().execute(file_url);

        MyService.this.stopService(intent);

        return super.onStartCommand(intent, flags, startId);
    }


    /**
     * Background Async Task to download file
     * */
    class DownloadFileFromURL extends AsyncTask<String, String, String> {

        /**
         * Before starting background thread
         * Show Progress Bar Dialog
         */
        @Override
        protected void onPreExecute() {
            super.onPreExecute();

        }

         * Downloading file in background thread
         */
        @Override
        protected String doInBackground(String... f_url) {
            int count;
            try {
                URL url = new URL(f_url[0]);
                URLConnection conection = url.openConnection();
                // 6yi7 conection.connect();
                conection.setRequestProperty("Accept-Encoding", "identity");

                // getting file length
                int lenghtOfFile = conection.getContentLength();

                // input stream to read file - with 8k buffer
                InputStream input = new BufferedInputStream(url.openStream(), 8192);

                // Output stream to write file
                OutputStream output = new FileOutputStream(c.getA());

                byte data[] = new byte[1024];

                long total = 0;

                while ((count = input.read(data)) != -1) {
                    total += count;
                    // publishing the progress....
                    // After this onProgressUpdate will be called
                    publishProgress("" + (int) ((total * 100) / lenghtOfFile));

                    // writing data to file
                    output.write(data, 0, count);
                }

                // flushing output
                output.flush();

                // closing streams
                output.close();
                input.close();

            } catch (Exception e) {
                Log.e("Error: ", e.getMessage());
            }

            return null;
        }


        @Override
        protected void onPostExecute(String file_url) {

            Toast.makeText(MyService.this, "Downloaded Succesfully.. check Jithin's folder 2 see file...", Toast.LENGTH_LONG).show();

            //my_image.setImageDrawable(Drawable.createFromPath(imagePath));
        }
    }
}

My Main Activity code is..

 public void download(View view) {
        String value = getIntent().getExtras().getString("id");
        if (value.equals("Song0")) {
            Intent i=new Intent(Song_List.this, MyService.class);
            startActivity(i);
            Toast.makeText(Song_List.this, "Downloading..........", Toast.LENGTH_SHORT).show();
        }
}

Answer 1

MyService is the extention of Service. So you have to use startService(Intent).

so your code may look like this :

public void download(View view) {
        String value = getIntent().getExtras().getString("id");
        if (value.equals("Song0")) {
            Intent i=new Intent(Song_List.this, MyService.class);
            startService(i);
            Toast.makeText(Song_List.this, "Downloading..........", Toast.LENGTH_SHORT).show();
        }
}

Answer 2

First of all you should start your service like this not with startActivity

public void download(View view) {
        String value = getIntent().getExtras().getString("id");
        if (value.equals("Song0")) {
            Intent i=new Intent(Song_List.this, MyService.class);
            startService(i);
            Toast.makeText(Song_List.this, "Downloading..........", Toast.LENGTH_SHORT).show();
        }
    }

after stop service when your file download is completed

Answer 3

Change your code from,

Intent i=new Intent(Song_List.this, MyService.class);
startActivity(i); 

this to,

Intent i=new Intent(Song_List.this, MyService.class);
startService(i);