CODEWITHSUNDEEP
javanettyfuture
Maxi Wu
Maxi Wu

Reputation: 1484

How Netty ChannelFuture works?

I've read Netty Guide, it does not explain much on ChannelFuture. I find ChannelFuture is a complex idea when applying it.

What I am trying to do is to write message to a context after it's initial response. Different from typical request/response flow. I need a flow like this:

  1. Client send request -> Server (netty)
  2. Server send a response with ctx.writeAndFlush(msg);
  3. Server send some more message to that ctx after step 2 is complete.

The problem is that if I do something like this, the second write will not send out:

ctx.writeAndFlush(response);
Message newMsg = createMessage();
ctx.writeAndFlush(newMsg);   //will not send to client

Then I try to use ChannelFuture, it works, but I am not sure if I am logically correct:

ChannelFuture msgIsSent = ctx.writeAndFlush(response);
if(msgIsSent.isDone())
{
    Message newMsg = createMessage();
    ctx.writeAndFlush(newMsg);   //this works
}

or should I use a ChannelFutureListener() instead?

ChannelFuture msgIsSent = ctx.writeAndFlush(response);
msgIsSent.addListener(new ChannelFutureListener(){
@Override
public void operationComplete(ChannelFuture future)
    {
       Message newMsg = createMessage();
       ctx.writeAndFlush(newMsg);
    }
});

Will this also works?

Which one is the best practice approach? Is there any potential problem using method 2?

Upvotes: 2

Views: 7869

Answers (3)

VAsia.k
VAsia.k

Reputation: 1

Try this:

    ctx.channel().writeAndFlush(response);
    Message newMsg = createMessage();
    ctx.channel().writeAndFlush(newMsg);

Channel.write() always starts from the tail of the ChannelPipeline.

ChannelHandlerContext.write() starts from the current position of the ChannelHandler.

Upvotes: 0

Nicholas
Nicholas

Reputation: 16056

#2 looks better but make sure to test if the operation was successful. If not, use future.getCause() to access the exception. Not that it will change the functionality, but you can shorten the code by simply adding the listener directly on the result of the write call, I.e. you don't need to declare the future itself since it will be provided in the callback.

Upvotes: -1

Frederic Brégier
Frederic Brégier

Reputation: 2206

Of course, this depends too on your "protocol" (meaning for instance if you use HTTP, sending 2 answears for the same request is not supported by HTTP protocol). But let say your protocol allows you to send multiple response parts:

Netty add messages to send to the pipeline, respecting the order.

So in your first example, I'm a bit surprised it does not work:

ctx.writeAndFlush(response);
Message newMsg = createMessage();
ctx.writeAndFlush(newMsg); // should send the message

However it could be lead by your protocol. For instance, this could happen:

response in message queue to send
flush not yet done
newMsg in message queue to send
flush now come but protocol does not support 2 messages so only send first one

So if your protocol must admit that first message is sent already, then you have to wait for the first, so doing something like:

ctx.writeAndFlush(response).addListener(new ChannelFutureListener() {
  @Override
  public void operationComplete(ChannelFuture future) {
    if (future.isDone()) {
      Message newMsg = createMessage();
      ctx.writeAndFlush(newMsg);
    } else { // an error occurs, do perhaps something else
    }
  }
});

So your last proposal (I've just don't create a ChannelFuture but directly used the result of writeAndFlush, but both are equals). Just take care of the case where operationComplete does not mean it is in success.

Upvotes: 3

Related Questions