CODEWITHSUNDEEP
c#asp.net
HEEN
HEEN

Reputation: 4721

Reducing the lines of code based on conditions

I have 2 if conditions, but with this line of code is getting increased. Can I reduce some code so that it works the same as it is now.

if (ddlProject.SelectedValue != "0" && ddlBuilding.SelectedValue != "0")
    {
        string queryInsert;
        DataTable dtval = new DataTable();
        dtval = CF.ExecuteDT("Select BOOKING_NO from xxacl_pN_LEASES_ALL where project_id = '" + ddlProject.SelectedValue + "' and building_id = '" + ddlBuilding.SelectedValue + "'");

        for (int i = 0; i < dtval.Rows.Count; i++)
        {
            string StrSeq = CF.ExecuteScaler("Select xxcus.xxacl_pN_LEASES_ALL_SEQ.next_val from xxacl_pN_LEASES_ALL");
            queryInsert = "Insert into xxacl_pN_LEASES_ALL_h select '" + StrSeq + "', SYSDATE FROM xxacl_pn_leases_all where booking_no = '" + dtval.Rows[i]["BOOKING_NO"].ToString() + "'";
            OracleConnection conUpdate = new OracleConnection(System.Configuration.ConfigurationManager.ConnectionStrings["OracleConn"].ToString());
            OracleCommand cmd1 = new OracleCommand();
            string allQueryUpdate = queryInsert;
            cmd1.CommandText = allQueryUpdate;
            cmd1.Connection = conUpdate;
            conUpdate.Open();
            cmd1.ExecuteNonQuery();
        }

        string queryUpdate;
        queryUpdate = "update xxacl_pN_LEASES_ALL set ASSIGNED_TO = '" + ddlSalesUser.SelectedValue + "'";

        OracleConnection conUpdate1 = new OracleConnection(System.Configuration.ConfigurationManager.ConnectionStrings["OracleConn"].ToString());
        OracleCommand cmd2 = new OracleCommand();
        string allQueryUpdate1 = queryUpdate;
        cmd2.CommandText = allQueryUpdate1;
        cmd2.Connection = conUpdate1;
        conUpdate1.Open();
        cmd2.ExecuteNonQuery();
        ScriptManager.RegisterStartupScript(this, this.GetType(), "alert", "alert('Record updated successfully');window.location ='FrmHoldingCoordinateUpdate.aspx?Redirect=" + Request.QueryString["Redirect"] + "&userid=" + Request.QueryString["userid"].ToString() + "';", true);        
    }
    if (ddlProject.SelectedValue != "0" && ddlBuilding.SelectedValue == "0")
    {
        string queryInsert;
        DataTable dtval = new DataTable();
        dtval = CF.ExecuteDT("Select BOOKING_NO from xxacl_pN_LEASES_ALL where project_id = '" + ddlProject.SelectedValue + "' and building_id = '" + ddlBuilding.SelectedValue + "'");

        for (int i = 0; i < dtval.Rows.Count; i++)
        {
            string StrSeq = CF.ExecuteScaler("Select xxcus.xxacl_pN_LEASES_ALL_SEQ.next_val from xxacl_pN_LEASES_ALL");
            queryInsert = "Insert into xxacl_pN_LEASES_ALL_h select '" + StrSeq + "', SYSDATE FROM xxacl_pn_leases_all where booking_no = '" + dtval.Rows[i]["BOOKING_NO"].ToString() + "'";
            OracleConnection conUpdate = new OracleConnection(System.Configuration.ConfigurationManager.ConnectionStrings["OracleConn"].ToString());
            OracleCommand cmd1 = new OracleCommand();
            string allQueryUpdate = queryInsert;
            cmd1.CommandText = allQueryUpdate;
            cmd1.Connection = conUpdate;
            conUpdate.Open();
            cmd1.ExecuteNonQuery();
        }

        string queryUpdate;
        queryUpdate = "update xxacl_pN_LEASES_ALL set ASSIGNED_TO = '" + ddlSalesUser.SelectedValue + "'";

        OracleConnection conUpdate1 = new OracleConnection(System.Configuration.ConfigurationManager.ConnectionStrings["OracleConn"].ToString());
        OracleCommand cmd2 = new OracleCommand();
        string allQueryUpdate1 = queryUpdate;
        cmd2.CommandText = allQueryUpdate1;
        cmd2.Connection = conUpdate1;
        conUpdate1.Open();
        cmd2.ExecuteNonQuery();
        ScriptManager.RegisterStartupScript(this, this.GetType(), "alert", "alert('Record updated successfully');window.location ='FrmHoldingCoordinateUpdate.aspx?Redirect=" + Request.QueryString["Redirect"] + "&userid=" + Request.QueryString["userid"].ToString() + "';", true);        
    }

Just I am checking the conditions.Rest code is same

Upvotes: 0

Views: 75

Answers (2)

Ashutosh Vyas
Ashutosh Vyas

Reputation: 419

Improving upon the above answer, I do not see a need for multiple IF conditions either.

if (ddlProject.SelectedValue != "0")
{
   UpdateDatabase();      
}

private void UpdateDatabase()
{
       string queryInsert;
        DataTable dtval = new DataTable();
        dtval = CF.ExecuteDT("Select BOOKING_NO from xxacl_pN_LEASES_ALL where project_id = '" + ddlProject.SelectedValue + "' and building_id = '" + ddlBuilding.SelectedValue + "'");

        for (int i = 0; i < dtval.Rows.Count; i++)
        {
            string StrSeq = CF.ExecuteScaler("Select xxcus.xxacl_pN_LEASES_ALL_SEQ.next_val from xxacl_pN_LEASES_ALL");
            queryInsert = "Insert into xxacl_pN_LEASES_ALL_h select '" + StrSeq + "', SYSDATE FROM xxacl_pn_leases_all where booking_no = '" + dtval.Rows[i]["BOOKING_NO"].ToString() + "'";
            OracleConnection conUpdate = new OracleConnection(System.Configuration.ConfigurationManager.ConnectionStrings["OracleConn"].ToString());
            OracleCommand cmd1 = new OracleCommand();
            string allQueryUpdate = queryInsert;
            cmd1.CommandText = allQueryUpdate;
            cmd1.Connection = conUpdate;
            conUpdate.Open();
            cmd1.ExecuteNonQuery();
        }

        string queryUpdate;
        queryUpdate = "update xxacl_pN_LEASES_ALL set ASSIGNED_TO = '" + ddlSalesUser.SelectedValue + "'";

        OracleConnection conUpdate1 = new OracleConnection(System.Configuration.ConfigurationManager.ConnectionStrings["OracleConn"].ToString());
        OracleCommand cmd2 = new OracleCommand();
        string allQueryUpdate1 = queryUpdate;
        cmd2.CommandText = allQueryUpdate1;
        cmd2.Connection = conUpdate1;
        conUpdate1.Open();
        cmd2.ExecuteNonQuery();
        ScriptManager.RegisterStartupScript(this, this.GetType(), "alert", "alert('Record updated successfully');window.location ='FrmHoldingCoordinateUpdate.aspx?Redirect=" + Request.QueryString["Redirect"] + "&userid=" + Request.QueryString["userid"].ToString() + "';", true);        
}

Upvotes: 0

RBT
RBT

Reputation: 25917

I compared the code written in both the if statements using winMerge tool. There is absolutely no difference of even a single bit. You should simply create a private method to enable code reuse in your module. This is how it might look. Without doubt still more refactoring can be done even in the new function UpdateDatabase that I've written to align it to the principles of clean-code.

if (ddlProject.SelectedValue != "0" && ddlBuilding.SelectedValue != "0")
{
   UpdateDatabase();      
}

if (ddlProject.SelectedValue != "0" && ddlBuilding.SelectedValue == "0")
{
    UpdateDatabase();       
}

private void UpdateDatabase()
{
       string queryInsert;
        DataTable dtval = new DataTable();
        dtval = CF.ExecuteDT("Select BOOKING_NO from xxacl_pN_LEASES_ALL where project_id = '" + ddlProject.SelectedValue + "' and building_id = '" + ddlBuilding.SelectedValue + "'");

        for (int i = 0; i < dtval.Rows.Count; i++)
        {
            string StrSeq = CF.ExecuteScaler("Select xxcus.xxacl_pN_LEASES_ALL_SEQ.next_val from xxacl_pN_LEASES_ALL");
            queryInsert = "Insert into xxacl_pN_LEASES_ALL_h select '" + StrSeq + "', SYSDATE FROM xxacl_pn_leases_all where booking_no = '" + dtval.Rows[i]["BOOKING_NO"].ToString() + "'";
            OracleConnection conUpdate = new OracleConnection(System.Configuration.ConfigurationManager.ConnectionStrings["OracleConn"].ToString());
            OracleCommand cmd1 = new OracleCommand();
            string allQueryUpdate = queryInsert;
            cmd1.CommandText = allQueryUpdate;
            cmd1.Connection = conUpdate;
            conUpdate.Open();
            cmd1.ExecuteNonQuery();
        }

        string queryUpdate;
        queryUpdate = "update xxacl_pN_LEASES_ALL set ASSIGNED_TO = '" + ddlSalesUser.SelectedValue + "'";

        OracleConnection conUpdate1 = new OracleConnection(System.Configuration.ConfigurationManager.ConnectionStrings["OracleConn"].ToString());
        OracleCommand cmd2 = new OracleCommand();
        string allQueryUpdate1 = queryUpdate;
        cmd2.CommandText = allQueryUpdate1;
        cmd2.Connection = conUpdate1;
        conUpdate1.Open();
        cmd2.ExecuteNonQuery();
        ScriptManager.RegisterStartupScript(this, this.GetType(), "alert", "alert('Record updated successfully');window.location ='FrmHoldingCoordinateUpdate.aspx?Redirect=" + Request.QueryString["Redirect"] + "&userid=" + Request.QueryString["userid"].ToString() + "';", true);        
}

Upvotes: 2

Related Questions