Preference fragment returns null on transaction

Question

I'm trying to implement a preference fragment in my app, so I set preferences.xml file, fragment that is supposed to show preferences, and fragment transaction. When I try to show SettingsFragment, the app crashes with this error log:

java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Class java.lang.Object.getClass()' on a null object reference
                                                              at android.support.v4.app.BackStackRecord.doAddOp(BackStackRecord.java:431)
                                                              at android.support.v4.app.BackStackRecord.replace(BackStackRecord.java:481)
                                                              at android.support.v4.app.BackStackRecord.replace(BackStackRecord.java:472)
                                                              at com.ikurek.pwr.MainActivity.onNavigationItemSelected(MainActivity.java:145)
                                                              at android.support.design.widget.NavigationView$1.onMenuItemSelected(NavigationView.java:153)
                                                              at android.support.v7.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:810)
                                                              at android.support.v7.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:152)
                                                              at android.support.v7.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:957)
                                                              at android.support.design.internal.NavigationMenuPresenter$1.onClick(NavigationMenuPresenter.java:328)
                                                              at android.view.View.performClick(View.java:4780)
                                                              at android.view.View$PerformClick.run(View.java:19866)
                                                              at android.os.Handler.handleCallback(Handler.java:739)
                                                              at android.os.Handler.dispatchMessage(Handler.java:95)
                                                              at android.os.Looper.loop(Looper.java:135)
                                                              at android.app.ActivityThread.main(ActivityThread.java:5254)
                                                              at java.lang.reflect.Method.invoke(Native Method)
                                                              at java.lang.reflect.Method.invoke(Method.java:372)
                                                              at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
                                                              at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)

Why is this object null? How else am I supposed to set up a setting fragment? I know that solution for this is proably very simple, but somehow I cannot figure this out by myself. Here's my code:

Part that calls fragment transaction from MainActivity:

public boolean onNavigationItemSelected(MenuItem item) {

    Fragment fragment = null;
    Class fragmentClass = null;
    int id = item.getItemId();

    if (id == R.id.nav_news) {
        fragmentClass = NewsFragment.class;

    } else if (id == R.id.nav_map) {
        fragmentClass = CatFragment.class;

    } else if (id == R.id.nav_buildings) {
        fragmentClass = BuildingsFragment.class;

    } else if (id == R.id.nav_settings) {
       fragmentClass = SettingsFragment.class;


    } else if (id == R.id.nav_info) {
        fragmentClass = AppInfoFragment.class;


    } else if (id == R.id.nav_bugreport) {
        fragmentClass = ContactFragment.class;

    }


    try {
        fragment = (Fragment) fragmentClass.newInstance();
    } catch (Exception e) {
        e.printStackTrace();
    }


    FragmentManager fragmentManager = getSupportFragmentManager();
    fragmentManager.beginTransaction().replace(R.id.frameLayoutForFragments, fragment).commit();

    DrawerLayout drawer = (DrawerLayout) findViewById(R.id.drawer_layout);
    drawer.closeDrawer(GravityCompat.START);
    return true;
}

My preferences.xml:

<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android">
<CheckBoxPreference
    android:defaultValue="false"
    android:key="saveLastPosition"
    android:summary="1st check box"
    android:title="Check"/>
<CheckBoxPreference
    android:defaultValue="true"
    android:key="keepScreenOn"
    android:summary="2nd check box"
    android:title="Box"/>
</PreferenceScreen>

And my SettingsFragment:

public class SettingsFragment extends PreferenceFragment {

public SettingsFragment() {
    // Required empty public constructor
}


public static SettingsFragment newInstance() {
    SettingsFragment fragment = new SettingsFragment();

    return fragment;
}

@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    addPreferencesFromResource(R.xml.preferences);
}


}

Answer 1

Well from what I can tell you are passing a null fragment to your fragment manager. As you will notice:

Fragment fragment = null;
Class fragmentClass = SettingsFragment.class;
FragmentManager fragmentManager = getSupportFragmentManager();
fragmentManager.beginTransaction().replace(R.id.frameLayoutForFragments, fragment).commit();

You have:

Fragment fragment = null;

You never actually declare this as a SettingsFragment. You should either have:

Fragment fragment = new SettingsFragment();

Or declare it in your replace statement.

Class fragmentClass = SettingsFragment.class;
FragmentManager fragmentManager = getSupportFragmentManager();
fragmentManager.beginTransaction().replace(R.id.frameLayoutForFragments, new SettingsFragment()).commit();