CODEWITHSUNDEEP
arrayspowershell
Alexander Meise
Alexander Meise

Reputation: 1438

Printing an array in Powershell

I am trying to print an array (I tried both with a for loop and directly with .ToString()), but I allways get a System.Object output.

The content of the array is the result of this command:

$singleOutput = Invoke-Command -ComputerName $server -ScriptBlock {
    Get-ChildItem C:\*.txt -Recurse |
        Select-String -Pattern "password" -AllMatches
}

This is the output I'm getting:

System.Object[]

What am I missing?

EDIT:

This is the whole function: 

foreach ($server in $servidores) {
    $result = @()
    Write-Output ("---Searching on Server:---" + $server + "----at:" +
        (Get-Date).ToString() + "----")
    $singleOutput = Invoke-Command -ComputerName $server -ScriptBlock {
        Get-ChildItem C:\*.txt -Recurse |
            Select-String -Pattern "password" -AllMatches
    }
    $result += $singleOutput

    Write-Host $result.ToString()
}
Read-Host -Prompt "Press Enter to exit"

I also tried with:

foreach ($i in $result) {
    $result[$i].ToString()
}

Upvotes: 23

Views: 159019

Answers (1)

Ansgar Wiechers
Ansgar Wiechers

Reputation: 200193

You're using Select-String, which produces MatchInfo objects. Since it looks like you want the whole matching lines from the files you probably should return just the value of the Line property of the MatchInfo objects. Also, your array handling is way too complicated. Just output whatever Invoke-Command returns and capture the loop output in a variable. For status output inside the loop use Write-Host, so that the messages don't get captured in $result.

$result = foreach ($server in $servidores) {
    Write-Host ("--- Searching on Server: $server at: " + (Get-Date).ToString())
    Invoke-Command -ComputerName $server -ScriptBlock {
        Get-ChildItem C:\*.txt -Recurse |
            Select-String -Pattern "password" -AllMatches |
            Select-Object -Expand Line
    }
}

If you also need the hostname you could add it with a calculated property and return custom objects:

$result = foreach ($server in $servidores) {
    Write-Host ("--- Searching on Server: $server at: " + (Get-Date).ToString())
    Invoke-Command -ComputerName $server -ScriptBlock {
        Get-ChildItem C:\*.txt -Recurse |
            Select-String -Pattern "password" -AllMatches |
            Select-Object @{n='Server';e={$env:COMPUTERNAME}},Line
    }
}

You output an array simply by echoing the array variable:

PS C:\> $result
Server    Line
------    ----
...       ...

To get custom-formatted output you can for instance use the format operator (-f):

$result | ForEach-Object {
  '{0}: {1}' -f $_.Server, $_.Line
}

Upvotes: 45

Related Questions