combining search with pagination not outputting correctly

Question

At present, the pagination feature is working fine when displaying ALL results, or if i manipulate the query to show specific results (WHERE X = Y) and i can happily cycle through all pages. Now, i have tried to implement a search feature.

problem#1 - it only displays the FIRST page of the inputted search results correctly, when i go to next page it shows other items from the database (not relevant to the search). [SOLVED] see UPDATES in script.

problem#2 - the number of pages returned are calculated from the whole database (shows +400 pages) and not e.g. only 3 pages because the search results should be 45 items.

an outline of my structure is:

query("SELECT * FROM items "); //**FOCUS 1**
$pages->set_total($stmt->rowCount()); //pass number of records to PAGINATION

// SEARCH QUERY
if(isset($_GET['search_item'])){ // UPDATE-was POST
    $search_item = $_GET['search_item']; // UPDATE-was POST

    $stmt = $db->prepare("SELECT * FROM items WHERE item_name LIKE   '%".$search_item."%' OR item_code LIKE '%".$search_item."%' ORDER BY item_name ".$pages->get_limit());

$stmt->execute(array("%$search_item%"));
$set_total = ($stmt->rowCount());
//$min_length = 2; not necessary for example
}
?>


 
    
    




page_links('index.php?p=index&search_item='.$search_item.'&'); //**FOCUS 3** // UPDATE-was just  echo $pages->page_links();
?>

Pagination Class:

class Paginator {

    private $_perPage;  // set the number of items per page. |@var numeric
    private $_instance; // set get parameter for fetching the page number | @var string
    private $_page; // sets the page number. | @var numeric
    private $_limit;    // set the limit for the data source | @var string
    private $_totalRows = 0;    // set the total number of records/items. | @var numeric

    // __construct | pass values when class is istantiated | @param numeric     $_perPage  sets the number of iteems per page | @param numeric  $_instance sets the instance for the GET parameter
    public function __construct($perPage,$instance){
        $this->_instance = $instance;
        $this->_perPage = $perPage;
        $this->set_instance();  
    }

    // get_start | creates the starting point for limiting the dataset | @return numeric
    private function get_start(){
        return ($this->_page * $this->_perPage) - $this->_perPage;
    }

    // set_instance | sets the instance parameter, if numeric value is 0 then set to 1 | @var numeric
    private function set_instance(){
        $this->_page = (int) (!isset($_GET[$this->_instance]) ? 1 : $_GET[$this->_instance]); // 1 was changed to 1
        $this->_page = ($this->_page == 0 ? 1 : $this->_page); // 1 was changed to 5
    }

    // set_total | collect a numberic value and assigns it to the totalRows | @var numeric
    public function set_total($_totalRows){
        $this->_totalRows = $_totalRows;
    }

    /**
    * get_limit
    * returns the limit for the data source, calling the get_start method and passing in the number of items perp page
    * @return string
    */
    public function get_limit(){
        return "LIMIT ".$this->get_start().",$this->_perPage";
    }

    /**
    * page_links
    * create the html links for navigating through the dataset
    * @var sting $path optionally set the path for the link
    * @var sting $ext optionally pass in extra parameters to the GET
    * @return string returns the html menu
    */
    public function page_links($path='?',$ext=null) {
        $adjacents = "2";
        $prev = $this->_page - 1;
        $next = $this->_page + 1;
        $lastpage = ceil($this->_totalRows/$this->_perPage);
        $lpm1 = $lastpage - 1;

        $pagination = "";
        if($lastpage > 1) {
        $pagination .= "";
        if ($this->_page > 1)
        $pagination.= "«";
        else
        $pagination.= "«";   

        if ($lastpage < 7 + ($adjacents * 2)) { //7
            for ($counter = 1; $counter <= $lastpage; $counter++) {
                if ($counter == $this->_page)
                $pagination.= "$counter";
                else
                $pagination.= "$counter";                   
            }
        }
        elseif($lastpage > 3 + ($adjacents * 2)) { //3
            if($this->_page < 1 + ($adjacents * 2)) {
                for ($counter = 1; $counter < 4 + ($adjacents * 2); $counter++) { //4
                    if ($counter == $this->_page)
                    $pagination.= "$counter";
                    else
                    $pagination.= "$counter";                   
                }
                $pagination.= "...";
                $pagination.= "$lpm1";
                $pagination.= "$lastpage";       
            }
            elseif($lastpage - ($adjacents * 2) > $this->_page && $this->_page > ($adjacents * 2)) {

                $pagination.= "1";
                $pagination.= "2";
                $pagination.= "...";
                for ($counter = $this->_page - $adjacents; $counter <= $this->_page + $adjacents; $counter++) {
                    if ($counter == $this->_page)
                    $pagination.= "$counter";
                    else
                    $pagination.= "$counter";                   
                }

                $pagination.= "..";
                $pagination.= "$lpm1";
                $pagination.= "$lastpage";       
            } else {

                $pagination.= "1";
                $pagination.= "2";
                $pagination.= "..";
                for ($counter = $lastpage - (2 + ($adjacents * 2)); $counter <= $lastpage; $counter++) {
                    if ($counter == $this->_page)
                    $pagination.= "$counter";
                    else
                    $pagination.= "$counter";                   
                }
            }
        }

        if ($this->_page < $counter - 1)
        $pagination.= "»";
        else
        $pagination.= "»";
        $pagination.= "
";       
    }


    return $pagination;
}
}

attempts to resolve:

I have been messing around with the code and can't recall everything i have tried but things i have looked at are the FOCUS areas.

FOCUS 1 i think that in order to only generate pagination for the total results of search output i need to add something like ("WHERE item_name LIKE '%".$search_item."%' "), which has worked when i code like ("WHERE item_name LIKE 'ford') it displays the correct number of pages, but when i cycle through the results are not correct. simply adding '%".$search_item."%' to the query generates an undefined variable error, which i understand as '%".$search_item."%' has not been set until later in the coding.

Focus 2 i have tried changing method to GET and action to action="index.php?p=index&search=". now this changes the URL to what i think should be correct 'index.php?search_item=ford' BUT it still doesnt work as part of the search feature as i have to hard code the WHERE to display results (FOCUS 1).

Focus 3 i cant remember exactly what i did, something similar to the action in Focus 2, but when i hovered over the seperate pages it showed the correct URL paths i would expect.

It seems that when i am trying one thing, it works for one of the Focus points, but then doesn't somewhere else.

CLOSEST IV GOT SO FAR! i have now got items displaying correctly, and am able to cycle through pages correctly! i have amended the code above to what i have now, with what i 'had' in the comments. The problem i now have is showing the correct number of pages in pagination - it shows all +400 pages, however my search variable passes over to each page and i can cycle through searched results and.. it 'cuts off' where it is supposed to e.g. if i have only 50 results, then it will show results for page 1,2,3 then on pages 4+ displays nothing.

could anyone please inform me where i am going wrong or any advice on what i should be looking at.

combining search with pagination not outputting correctly

Answers (1)

Focus 1

Focus 2

Related Questions