CODEWITHSUNDEEP
pythonpyqtpyqt4
mhernandez
mhernandez

Reputation: 616

PyQT4: why does QDialog returns from exec_() when setVisible(false)

I'm using Python 2.7 and PyQT4.

I want to hide a modal QDialog instance and later on show it again. However, when dialog.setVisible(false) is called (e.g., using QTimer), the dialog.exec_() call returns (with QDialog.Rejected return value).

However, according to http://pyqt.sourceforge.net/Docs/PyQt4/qdialog.html#exec, the _exec() call should block until the user closes the dialog.

Is there a way to hide the dialog without _exec() returning?

#!/usr/bin/env python
# -*- coding: utf-8 -*-

import sys
import os
from PyQt4 import QtGui, QtCore


class MyDialog(QtGui.QDialog):
    def __init__(self, parent):
        QtGui.QDialog.__init__(self, parent)

    def closeEvent(self, QCloseEvent):
        print "Close Event"

    def hideEvent(self, QHideEvent):
        print "Hide Event"


class MyWindow(QtGui.QMainWindow):
    def __init__(self):
        QtGui.QMainWindow.__init__(self)
        self.setWindowTitle("Main Window")
        button = QtGui.QPushButton("Press me", self)
        button.clicked.connect(self.run_dialog)

    def run_dialog(self):
        self.dialog = MyDialog(self)
        self.dialog.setModal(True)
        self.dialog.show()
        QtCore.QTimer.singleShot(1000, self.hide_dialog)
        status = self.dialog.exec_()
        print "Dialog exited with status {}".format(status), "::", QtGui.QDialog.Accepted, QtGui.QDialog.Rejected

    def hide_dialog(self):
        self.dialog.setVisible(False)
        # self.dialog.setHidden(True)


if __name__ == '__main__':
    app = QtGui.QApplication([])
    w = MyWindow()
    w.show()
    sys.exit(app.exec_())

PS1: This code prints the following output:

Hide Event
Dialog exited with status 0 :: 1 0

(the close event is not called).

PS2: For context, I'm trying to implement a SystemTrayIcon that allows to hide and restore a QMainWindow (this part is fine) and possibly its modal QDialog without closing the dialog.

Thanks!

Upvotes: 1

Views: 1234

Answers (2)

ekhumoro
ekhumoro

Reputation: 120758

You can bypass the normal behaviour of QDialog.setVisible (which implicitly closes the dialog), by calling the base-class method instead:

    def hide_dialog(self):
        # self.dialog.setVisible(False)
        QtGui.QWidget.setVisible(self.dialog, False)

However, it might be preferrable to connect to the dialog's finished() signal, rather than using exec(), and explicitly reject() the dialog in its closeEvent.

#!/usr/bin/env python
# -*- coding: utf-8 -*-

import sys
import os
from PyQt4 import QtGui, QtCore

class MyDialog(QtGui.QDialog):
    def __init__(self, parent):
        QtGui.QDialog.__init__(self, parent)
        layout = QtGui.QHBoxLayout(self)
        for title, slot in ('Ok', self.accept), ('Cancel', self.reject):
            button = QtGui.QPushButton(title)
            button.clicked.connect(slot)
            layout.addWidget(button)

    def closeEvent(self, QCloseEvent):
        print "Close Event"
        self.reject()

    def hideEvent(self, QHideEvent):
        print "Hide Event"

class MyWindow(QtGui.QMainWindow):
    def __init__(self):
        QtGui.QMainWindow.__init__(self)
        self.setWindowTitle("Main Window")
        button = QtGui.QPushButton("Press me", self)
        button.clicked.connect(self.run_dialog)

    def run_dialog(self):
        self.dialog = MyDialog(self)
        self.dialog.finished.connect(self.dialog_finished)
        self.dialog.setModal(True)
        self.dialog.show()
        QtCore.QTimer.singleShot(3000, self.dialog.hide)

    def dialog_finished(self, status):
        print "Dialog exited with status:", status

if __name__ == '__main__':

    app = QtGui.QApplication([])
    w = MyWindow()
    w.show()
    sys.exit(app.exec_())

Upvotes: 3

mhernandez
mhernandez

Reputation: 616

In case anyone is interested, the following code provides a quick-and-dirty way to circunvent the problem for me, although it does not really answer the question.

#!/usr/bin/env python
# -*- coding: utf-8 -*-
"""Extension of the QDialog class so that exec_() does not exit when hidden.

Dialogs inheriting will only exit exec_() via close(), reject() or accept()
"""

from PyQt4 import QtGui, QtCore
from PyQt4.QtGui import *
from PyQt4.QtCore import *

class HideableQDialog(QDialog):
    def __init__(self, *args, **kwargs):
        super(HideableQDialog, self).__init__(*args, **kwargs)
        self._mutex = QMutex()
        self._is_finished = False
        self._finished_condition = QWaitCondition()
        self.finished.connect(self._finish_dialog)

    def _finish_dialog(self):
        self._is_finished = True
        self._finished_condition.wakeOne()

    def close(self):
        super(HideableQDialog, self).close()
        self._finish_dialog()

    def reject(self):
        super(HideableQDialog, self).reject()
        self._finish_dialog()

    def accept(self):
        super(HideableQDialog, self).accept()
        self._finish_dialog()

    def exec_(self):
        status = super(HideableQDialog, self).exec_()
        self._mutex.lock()
        condition_succedeed = False
        while not condition_succedeed and not self._is_finished:
            condition_succedeed = self._finished_condition.wait(self._mutex, 10)
            QApplication.processEvents()
        self._mutex.unlock()

Upvotes: 0

Related Questions