CODEWITHSUNDEEP
javaloopswhile-loop
user6793735
user6793735

Reputation:

Java: Hangman game, 10 chances, but only 5 lives

I'm creating a little mini game of Hangman. The user has 10 chances to guess, but only 5 lives.

The app works, but will continue after the 5th life, even though, I was hoping it would throw the player out of that loop.

The instantiable class (Hangman.java) is working without problems.

The secret word is "julie" as described in the instantiable class.

My App class:

    import javax.swing.JOptionPane;

    public class HangmanApp {

    public static void main(String args[]) {
    String input, secret, result, playAgain;
    char guess;
    int i, j, k, lives;

    Hangman myHangman = new Hangman();

    do{
        JOptionPane.showMessageDialog(null, "Hello, welcome to Hangman! You have 10 chances but only 5 lives! Best of luck");

        lives = 5;

        for (j = 10; j > 0; j--) {

            while (lives >= 0){
                input = JOptionPane.showInputDialog(null, "Please enter a letter");
                guess = input.charAt(0);

                //process
                myHangman.setGuess(guess);
                myHangman.compute();
                result = myHangman.getResult();

                if ((input.charAt(0) == 'j') || (input.charAt(0) == 'u') || (input.charAt(0) == 'l') || (input.charAt(0) == 'i') || (input.charAt(0) == 'e')) {
                    JOptionPane.showMessageDialog(null, "That letter is in the word! Current correct letters:  " + result + ".");
                } else {
                    lives--;
                    JOptionPane.showMessageDialog(null, "Sorry, that letter is not there. Current correct letters:  " + result + ".");
                }

                //output
                //JOptionPane.showMessageDialog(null, "Current correct letters:  " + result);

            };
            lives = -1;
        }
        result = myHangman.getResult();
        secret = myHangman.getSecret();

        if (secret.equals(result)) {
            JOptionPane.showMessageDialog(null, "Congratulations, you got it!! The word was " + secret + ".");
        } else {
            JOptionPane.showMessageDialog(null, "Sorry, you didn't get it, better look next time! The word was " + secret + ".");
        }

        playAgain = JOptionPane.showInputDialog("Do you want to play again? yes/no");

    }while (playAgain.equals("yes"));
}

}

Upvotes: 0

Views: 183

Answers (2)

Adrian Colomitchi
Adrian Colomitchi

Reputation: 3992

    // don't need two nested cycles, you can do it in a single one
    // The cycle exits if any one of the conditions fail
    //  max attempts exhausted or all the lives are lost
    // -------------------v        v------------------------             
    for (j = 10, lives=5; j > 0 && lives > 0 ; j--) {
       // -------------------------------------^
       // j - the number of attempt is decremented for each trial,
       // no matter if successful or not

       //... the rest of cycle logic, which will decrement the lives
       //  only in cases of unsuccessful attempts

    }

Upvotes: 0

PinHead877
PinHead877

Reputation: 63

Try the following change:

while (lives > 0){

you start at 5 and then go down to 4 3 2 1 AND 0. with the change this will stop at 0

Upvotes: 3

Related Questions