CODEWITHSUNDEEP
java
user6283781
user6283781

Reputation:

How to find out which variable is throwing an exception?

I'm writing a program that culculates tip and total from bill and tip rate.

public void takeUserInput() {
    Scanner sc = new Scanner(System.in);    
    double billAmount;
    int tipRate;

    try {
        System.out.print("What is the bill? ");
        billAmount = sc.nextDouble();
        System.out.print("What is the tip percentage? ");
        tipRate = sc.nextInt();

        tc.calculate(billAmount, tipRate);
    } catch (InputMismatchException e1) {
        String errorMessage = "Please enter a valid number for the ";
        // errorMessage += billAmount or
        // errorMessage += tipRate ?
    }

I'm looking for a way to find out which variable throws InputMismatchException, so I can add which variable name into variable errorMessage and print to the screen.

Upvotes: 1

Views: 765

Answers (2)

GhostCat
GhostCat

Reputation: 140623

There are various simple ways to get there:

  1. Call hasNextXxx() prior calling nextXxx().
  2. If you go for one try/catch block per input, it is very clear within your catch block which variable caused the problem (you could then call a generic method with a specific error message to avoid code duplication)
  3. You could use reference types for your variables; if you use Double / Integer instead of double / int ... you could check which of the two variables is still null
  4. You put in a little boolean variable, like billAmountIsValid. Initially that variable is false, you turn it to true after the call to nextDouble(). Then you can easily check in your try block whether you got a valid billAmount.

After some more thinking: you really want a combination of 1 + 2: you see; when the users enters a correct billAmount; why would you want to forget about that value when the second value gives a bad second value? No - you should be looping for each variable, until you receive a valid input. And only then you start asking for the next value!

Upvotes: 1

weston
weston

Reputation: 54811

The variable isn't throwing the exception, the evaluation of the right hand side of the variable assignment is, and so there is no information in the exception to say which variable it was about to assign that to had it succeeded.

What you could consider instead is a new method that encompasses the prompting messages and retries:

billAmount = doubleFromUser(sc, "What is the bill? ", "bill");

Where doubleFromUser is:

static double doubleFromUser(Scanner sc, String prompt, String description){
    while(true) { //until there is a successful input
        try {
            System.out.print(prompt); //move to before the loop if you do not want this repeated
            return sc.nextDouble();
        } catch (InputMismatchException e1) {
            System.out.println("Please enter a valid number for the " + description);
        }
    }
}

You will need a different one for int and double, but if you have more prompts, you will save in the long run.

Upvotes: 0

Related Questions