Opencart Module Interal Error

Question

I've started creating a simple 'popular products' module for Opencart 2.3 just to get to grips with how to create modules in Opencart.

I'm having an issue where when I click to install the module from the extensions section in the backend I'm faced with an internal error page, some of my logic must be incorrect but I'm not all that sure where I'm going wrong. I was wondering whether anyone would be able to point out where my issues lie?

The module was intended just to be used on the default theme. I have labelled what files are what at the top commented out:

ADMIN FILES:

ADMIN CONTROLLER FILE



load->language('extension/module/popular');
    $this->document->setTitle($this->language->get('heading_title'));
    $this->load->model('extension/module');

    if (($this->request->server['REQUEST_METHOD'] == 'POST') && $this->validate()) {
      if (!isset($this->request->get['module_id'])) {
        $this->model_extension_module->addModule('popular', $this->request->post);
      } else {
        $this->model_extension_module->editModule($this->request->get['module_id'], $this->request->post);
      }

      $this->cache->delete('product');
      $this->session->data['success'] = $this->language->get('text_success');
      $this->response->redirect($this->url->link('extension/extension', 'token=' . $this->session->data['token'] . '&type=module', true));
    }

    $data['heading_title'] = $this->language->get('heading_title');
    $data['text_edit'] = $this->language->get('text_edit');
    $data['text_enabled'] = $this->language->get('text_enabled');
    $data['text_disabled'] = $this->language->get('text_disabled');

    $data['entry_name'] = $this->language->get('entry_name');
    $data['entry_limit'] = $this->language->get('entry_limit');
    $data['entry_width'] = $this->language->get('entry_width');
    $data['entry_height'] = $this->language->get('entry_height');
    $data['entry_status'] = $this->language->get('entry_status');

    $data['button_save'] = $this->language->get('button_save');
    $data['button_cancel'] = $this->language->get('button_cancel');

    if (isset($this->error['warning'])) {
      $data['error_warning'] = $this->error['warning'];
    } else {
      $data['error_warning'] = '';
    }

    if (isset($this->error['name'])) {
      $data['error_name'] = $this->error['name'];
    } else {
      $data['error_name'] = '';
    }

    if (isset($this->error['width'])) {
      $data['error_width'] = $this->error['width'];
    } else {
      $data['error_width'] = '';
    }

    if (isset($this->error['autoplay'])) {
      $data['error_autoplay'] = $this->error['autoplay'];
    } else {
      $data['error_autoplay'] = '';
    }

    if (isset($this->error['height'])) {
      $data['error_height'] = $this->error['height'];
    } else {
      $data['error_height'] = '';
    }


    $data['breadcrumbs'] = array();

    $data['breadcrumbs'][] = array(
      'text' => $this->language->get('text_home'),
      'href' => $this->url->link('common/dashboard', 'token=' . $this->session->data['token'], true)
    );

    $data['breadcrumbs'][] = array(
      'text' => $this->language->get('text_module'),
      'href' => $this->url->link('extension/extension', 'token=' . $this->session->data['token'] . '&type=module', true)
    );

    if (!isset($this->request->get['module_id'])) {
      $data['breadcrumbs'][] = array(
        'text' => $this->language->get('heading_title'),
        'href' => $this->url->link('extension/module/popular', 'token=' . $this->session->data['token'], true)
      );
    } else {
      $data['breadcrumbs'][] = array(
        'text' => $this->language->get('heading_title'),
        'href' => $this->url->link('extension/module/popular', 'token=' . $this->session->data['token'] . '&module_id=' . $this->request->get['module_id'], true)
      );
    }

    if (!isset($this->request->get['module_id'])) {
      $data['action'] = $this->url->link('extension/module/popular', 'token=' . $this->session->data['token'], true);
    } else {
      $data['action'] = $this->url->link('extension/module/popular', 'token=' . $this->session->data['token'] . '&module_id=' . $this->request->get['module_id'], true);
    }

    $data['cancel'] = $this->url->link('extension/extension', 'token=' . $this->session->data['token'] . '&type=module', true);

    if (isset($this->request->get['module_id']) && ($this->request->server['REQUEST_METHOD'] != 'POST')) {
      $module_info = $this->model_extension_module->getModule($this->request->get['module_id']);
    }

    $data['token'] = $this->session->data['token'];

    if (isset($this->request->post['name'])) {
      $data['name'] = $this->request->post['name'];
    } elseif (!empty($module_info)) {
      $data['name'] = $module_info['name'];
    } else {
      $data['name'] = '';
    }

    $this->load->model('catalog/product');

    $data['products'] = array();

    if (isset($this->request->post['product'])) {
      $products = $this->request->post['product'];
    } elseif (!empty($module_info)) {
      $products = $module_info['product'];
    } else {
      $products = array();
    }

    foreach ($products as $product_id) {
      $product_info = $this->model_catalog_product->getProduct($product_id);

      if ($product_info) {
        $data['products'][] = array(
          'product_id' => $product_info['product_id'],
          'name'       => $product_info['name']
        );
      }
    }

    if (isset($this->request->post['limit'])) {
      $data['limit'] = $this->request->post['limit'];
    } elseif (!empty($module_info)) {
      $data['limit'] = $module_info['limit'];
    } else {
      $data['limit'] = 5;
    }

    if (isset($this->request->post['width'])) {
      $data['width'] = $this->request->post['width'];
    } elseif (!empty($module_info)) {
      $data['width'] = $module_info['width'];
    } else {
      $data['width'] = 360;
    }

    if (isset($this->request->post['height'])) {
      $data['height'] = $this->request->post['height'];
    } elseif (!empty($module_info)) {
      $data['height'] = $module_info['height'];
    } else {
      $data['height'] = 360;
    }

    if (isset($this->request->post['autoplay'])) {
      $data['autoplay'] = $this->request->post['autoplay'];
    } elseif (!empty($module_info)) {
      $data['autoplay'] = $module_info['autoplay'];
    } else {
      $data['autoplay'] = 5000;
    }

    if (isset($this->request->post['status'])) {
      $data['status'] = $this->request->post['status'];
    } elseif (!empty($module_info)) {
      $data['status'] = $module_info['status'];
    } else {
      $data['status'] = '';
    }



    $data['header'] = $this->load->controller('common/header');
    $data['column_left'] = $this->load->controller('common/column_left');
    $data['footer'] = $this->load->controller('common/footer');

    $this->response->setOutput($this->load->view('extension/module/popular.tpl', $data));
  }

  protected function validate() {
    if (!$this->user->hasPermission('modify', 'extension/module/popular')) {
      $this->error['warning'] = $this->language->get('error_permission');
    }

    if ((utf8_strlen($this->request->post['name']) < 3) || (utf8_strlen($this->request->post['name']) > 64)) {
      $this->error['name'] = $this->language->get('error_name');
    }

    if (!$this->request->post['width']) {
      $this->error['width'] = $this->language->get('error_width');
    }

    if (!$this->request->post['height']) {
      $this->error['height'] = $this->language->get('error_height');
    }


    return !$this->error;
  }
}

ADMIN LANGUAGE FILE



ADMIN VIEW FILE





  
    
      
        
        
      
      
        
        
        
      
    
  
  
    
     
      
    
    
    
      
         
      
      
        
          
            
            
              
              
              
              
            
          
          
            
            
              
            
          
          
            
            
              
              
              
              
            
          
          
            
            
              
              
              
              
            
          
          
            
            
              
            
          
        
      
    
  




CATALOG FILES:

CONTROLLER FILE:



load->language('extension/module/popular');

    $data['heading_title']   = $this->language->get('heading_title');
    $data['text_tax']        = $this->language->get('text_tax');
    $data['button_cart']     = $this->language->get('button_cart');
    $data['button_wishlist'] = $this->language->get('button_wishlist');
    $data['button_compare']  = $this->language->get('button_compare');

    $this->load->model('catalog/product');
    $this->load->model('tool/image');

    $data['products'] = array();
    $product_data     = array();

    if(isset($setting['limit']) && $setting['limit']!=''){
      $setting['limit'] = $setting['limit'];
    }
    else{
      $setting['limit'] = 4;
    }


    $query = $this->db->query("SELECT p.product_id FROM " . DB_PREFIX . "product p LEFT JOIN " . DB_PREFIX . "product_to_store p2s ON (p.product_id = p2s.product_id) WHERE p.status = '1' AND p.date_available <= NOW() AND p2s.store_id = '" . (int)$this->config->get('config_store_id') . "' ORDER BY p.viewed DESC LIMIT " . (int)$setting['limit']);



    foreach ($query->rows as $result) {
      $product_data[$result['product_id']] = $this->model_catalog_product->getProduct($result['product_id']);
    }

    $results = $product_data;

    if ($results) {
      foreach ($results as $result) {
        if ($result['image']) {
          $image = $this->model_tool_image->resize($result['image'], $setting['width'], $setting['height']);
        } else {
          $image = $this->model_tool_image->resize('placeholder.png', $setting['width'], $setting['height']);
        }


        if (($this->config->get('config_customer_price') && $this->customer->isLogged()) || !$this->config->get('config_customer_price')) {
          $price = $this->currency->format($this->tax->calculate($result['price'], $result['tax_class_id'], $this->config->get('config_tax')));
        } else {
          $price = false;
        }

        if ((float)$result['special']) {
          $special = $this->currency->format($this->tax->calculate($result['special'], $result['tax_class_id'], $this->config->get('config_tax')));
        } else {
          $special = false;
        }

        if ($this->config->get('config_tax')) {
          $tax = $this->currency->format((float)$result['special'] ? $result['special'] : $result['price']);
        } else {
          $tax = false;
        }


        if ($this->config->get('config_review_status')) {
          $rating = $result['rating'];
        } else {
          $rating = false;
        }

        $data['products'][] = array(
          'product_id'   => $result['product_id'],
          'thumb'        => $image,
          'name'         => $result['name'],
          'description'  => utf8_substr(strip_tags(html_entity_decode($result['description'], ENT_QUOTES, 'UTF-8')), 0, $this->config->get('config_product_description_length')) . '..',
          'price'        => $price,
          'special'      => $special,
          'tax'          => $tax,
          'rating'       => $rating,
          'href'         => $this->url->link('product/product', 'product_id=' . $result['product_id']),
        );
      }

      if (file_exists(DIR_TEMPLATE . $this->config->get('config_template') . '/template/extension/module/popular.tpl')) {
        return $this->load->view($this->config->get('config_template') . '/template/extension/module/popular.tpl', $data);
      } else {
        return $this->load->view('default/template/extension/module/popular.tpl', $data);
      }
    }
  }
}


CATALOG LANGUAGE FILE





CATALOG VIEW FILE





  
  
    
      
      
        
        
        
        
          
          
          
          
          
          
          
        
        
        
        
          
          
          
           
          
          
           
          
        
        
      
      
        
        
        
      
    
  
  



I think that covers about everything. I'm sure I have the file locations set correctly too as I know these have changed since 2.0.

Any help here would be greatly appreciated.

Thank you.

HDP · Accepted Answer

Here, You have write wrong Controller class in both Controller files. You have forgot to mention "Extension" there.

Find and replace following code in both(ADMIN & CATALOG) controller files. and then check it.

Find:

class ControllerModulePopular extends Controller {

Replace:

class ControllerExtensionModulePopular extends Controller {

Opencart Module Interal Error

Answers (1)

Related Questions