CODEWITHSUNDEEP
delphi
Dylan
Dylan

Reputation: 1183

How to kill a thread in delphi?

In delphi, a method in TThread is terminate. It seems a subthread can not kill another thread by calling terminate or free. For example A(main form), B (a thread unit), C (another form).

B is sending data to main form and C (by calling syncronize), we tried to terminate B within C while B is executing by calling B.terminate. But this method does not work and B is still working until it ends in execute method.

Please help. Thank you in advance.

Upvotes: 23

Views: 49617

Answers (5)

Wodzu
Wodzu

Reputation: 6979

Actually,

currently most voted answer to this question is incorrect (so as 34 upvoters...) in regard how to forcefully kill a thread.

You do not use ThreadId as a parameter to TerminateThread procedure. Using ThreadId will cause most likely an "Invalid handle" error or in worse case scenerio - will kill a different thread.

You should pass a thread handle as a parameter:

TerminateThread(MyThread.Handle);

More about differences between thread's handle and id can be found here.

Edit

Seems @himself corrected his mistake after seeing my answer, so this is no longer relevant.

Upvotes: 19

himself
himself

Reputation: 4884

You have to check for Terminate in the thread for this to work. For instance:

procedure TMyThread.Execute;
begin
  while not Terminated do begin
    //Here you do a chunk of your work.
    //It's important to have chunks small enough so that "while not Terminated"
    //gets checked often enough.
  end;
  //Here you finalize everything before thread terminates
end;

With this, you can call

MyThread.Terminate;

And it'll terminate as soon as it finishes processing another chunk of work. This is called "graceful thread termination" because the thread itself is given a chance to finish any work and prepare for termination.

There is another method, called 'forced termination'. You can call:

TerminateThread(MyThread.Handle);

When you do this, Windows forcefully stops any activity in the thread. This does not require checking for "Terminated" in the thread, but potentially can be extremely dangerous, because you're killing thread in the middle of operation. Your application might crash after that.

That's why you never use TerminateThread until you're absolutely sure you have all the possible consequences figured out. Currently you don't, so use the first method.

Upvotes: 50

Ed Green
Ed Green

Reputation: 1

If you might want to terminate a thread then you could be better off spawning another app and killing that if you think its failed - windows will then tidy up after you.

Upvotes: 0

Timo
Timo

Reputation: 5176

All the Terminate method does is it sets the Terminated property to true. So you have to manually keep checking that property and then exit the thread method when it is set to true.

Upvotes: 3

Mason Wheeler
Mason Wheeler

Reputation: 84540

Terminate does not kill a thread; it sets the Terminated property to inform the thread that it needs to terminate. It's the thread's responsibility to watch for Terminated and shut itself down gracefully.

Upvotes: 13

Related Questions