CODEWITHSUNDEEP
vbaexcel
JBB
JBB

Reputation: 37

Excel crashing after adding Macro

I added a simple Macro to my Excel, but it seems to make my Excel crash a lot. Does anyone know why?

Here's the macro:

Sub PlanRelativityTesting()
With Sheets("Sheet1")
For i = 8 To 9
.Range("D11").value = .Range("G" & i).value          
Call AnotherMacro  
Sheets("Sheet2").Select    
        .Range("H" & i).value = Sheets("Sheet2").Range("AE20").value
        .Range("I" & i).value = Sheets("Sheet2").Range("AE21").value
        .Range("J" & i).value = Sheets("Sheet2").Range("AE22").value
        .Range("K" & i).value = Sheets("Sheet2").Range("AE23").value
        .Range("L" & i).value = Sheets("Sheet2").Range("AE24").value
        .Range("M" & i).value = Sheets("Sheet2").Range("AE25").value
        .Range("N" & i).value = Sheets("Sheet2").Range("AE26").value
        .Range("O" & i).value = Sheets("Sheet2").Range("AE27").value
        .Range("P" & i).value = Sheets("Sheet2").Range("AE28").value
        .Range("Q" & i).value = Sheets("Sheet2").Range("AE29").value
        .Range("R" & i).value = Sheets("Sheet2").Range("AE30").value
        .Range("S" & i).value = Sheets("Sheet2").Range("AE31").value
Next i       
.Select   
End With
End Sub

Upvotes: 0

Views: 74

Answers (1)

Tim Williams
Tim Williams

Reputation: 166306

As John notes your code could be more concise:

Sub PlanRelativityTesting()
    With Sheets("Sheet1")
        For i = 8 To 9
            .Range("D11").Value = .Range("G" & i).Value
            AnotherMacro
            .Range("H" & i).Resize(1, 12).Value = _
            Application.Transpose(Sheets("Sheet2").Range("AE20").Resize(12, 1).Value)
        Next i
        .Select
    End With
End Sub

The actual issue though is more likely to be in AnotherMacro

Upvotes: 1

Related Questions