CODEWITHSUNDEEP
pythondjango
Justin S
Justin S

Reputation: 1469

Change admin field filter name django 1.7 - ModelAdmin.list_filter

Basically, I am trying to create custom names for my filter fields as the original database values don't hold much meaning. The current values are 0,1 and ?. I followed the Django admin guide here https://docs.djangoproject.com/en/1.10/ref/contrib/admin/ on section ModelAdmin.list_filter.

Below is my code:

@admin.register(AuditPolicies)
class AuditPoliciesAdmin(admin.ModelAdmin):  
    list_filter = ('PolicyComparisonFilter',)


class PolicyComparisonFilter(admin.SimpleListFilter):
    title = _('Policy Comparison')
    parameter_name = 'SourceState'

    def lookups(self, request, model_admin):
        """
        Returns a list of tuples. The first element in each
        tuple is the coded value for the option that will
        appear in the URL query. The second element is the
        human-readable name for the option that will appear
        in the right sidebar.
        """
        return (
            ('0', _('No Match')),
            ('1', _('Match')),
            ('?', _('Missing')),
        )

    def queryset(self, request, queryset):
        """
        Returns the filtered queryset based on the value
        provided in the query string and retrievable via
        `self.value()`.
        """
        # Compare the requested value (either '80s' or '90s')
        # to decide how to filter the queryset.
        if self.value() == '0':
            return queryset.filter(SourceState__gte = '0')
        if self.value() == '1':
            return queryset.filter(SourceState__gte = '1')
        if self.value() == '?':
            return queryset.filter(SourceState__gte = '?')

And a couple of lines from my model(database):

364 STASH   master-bi-prod-s3-ilayer-sen-group-user /master-bi-prod-s3-ilayer-sen-group-user.json   1   MASTER  master-bi-prod-s3-ilayer-sen-group-user arn:aws:iam::588738232867:policy/master-bi-prod-s3-ilayer-sen-group-user    1   2016-11-17 04:04:16.117000
365 STASH   master-bi-prod-s3-pop-admin /master-bi-prod-s3-pop-admin.json   0   MASTER  master-bi-prod-s3-pop-admin arn:aws:iam::588738232867:policy/master-bi-prod-s3-pop-admin    0   2016-11-17 04:04:16.117000

My database model:

class AuditPolicies(models.Model):
    ComparisonDate = models.DateTimeField(default=datetime.now(), blank=True)
    Source = models.CharField(max_length=32, blank=True, null=True)
    SourcePolicyName = models.CharField(max_length=64, blank=True, null=True)
    SourcePolicyPath = models.CharField(max_length=128, blank=True, null=True) # todo: check if this should be using models.SlugField()
    SourceState = models.CharField(max_length=2, blank=True, null=True)

    Target = models.CharField(max_length=32, blank=True, null=True)
    TargetPolicyName = models.CharField(max_length=64, blank=True, null=True)
    TargetPolicyPath = models.CharField(max_length=128, blank=True, null=True)
    TargetState = models.CharField(max_length=2, blank=True, null=True)

    class Meta(object):
        verbose_name_plural = "Audit Policies"

The error I get when I try to run Django is:

ERRORS:
<class 'policy_manager.apps.policy.admin.AuditPoliciesAdmin'>: (admin.E116) The value of 'list_filter[0]' refers to 'PolicyComparisonFilter', which does not refer to a Field.

What I'm after is changing the values in the red box below:

enter image description here

Upvotes: 0

Views: 522

Answers (1)

Ewa Janikowska
Ewa Janikowska

Reputation: 88

I think your third line should look like this:

list_filter = (PolicyComparisonFilter, )

Without the quotes.

Upvotes: 2

Related Questions