CODEWITHSUNDEEP
javascriptangularjspromisees6-promise
2b2a
2b2a

Reputation: 95

Angular "Cannot read property 'then' of undefined" with promise

I am stuck on why my promises aren't working. From the other articles I have looked at, I think I am doing it correctly. Here is the code I have currently:

Factory code

factory.isLoggedIn = function() {
  $http.get('/api/v1/fitbit/auth')
      .success((data) => {
           return data.status;
       })
       .error((error) => {
           console.log('Error: ' + error);
       });
}

Controller code

    $scope.fitbitAuth = function() {
        FitbitFactory.isLoggedIn()
            .then(
                function(data) {
                    $scope.fitbitStatus = data;
                },
                function(errorData) {
                    console.log(errorData);
                });
        return $scope.fitbitStatus;
    };

From my understanding of promises, the return $scope.fitbitStatus should be populating the $scope.fitbitAuth, but it isn't. I am also returning a boolean in the Factory, which should be populating $scope.fitbitStatus.

Upvotes: 2

Views: 2900

Answers (2)

baao
baao

Reputation: 73221

You have to return something (the promise), or it is undefined.

Factory code:

factory.isLoggedIn = function() {
  return $http.get('/api/v1/fitbit/auth');
}

Controller code:

$scope.fitbitAuth = function() {
    return FitbitFactory.isLoggedIn()
        .then(
            function(data) {
                $scope.fitbitStatus = data;
            },
            function(errorData) {
                console.log(errorData);
            });

};

The complete success/error block in your factory is not necessary and should be removed. I'm also unsure why you return $scope.fitbitStatus; as it is undefined at the time of return.

Edit: Edited the answer to actually return the promise.

Upvotes: 2

Pankaj Parkar
Pankaj Parkar

Reputation: 136134

Currently you haven't return anything from isLoggedIn factory method and you are calling .then method over it.

To make it working return $http promiseobject from service method. In your case you could simply return$http.getmethod call which return promise object itself and then you can easily chain them up by callingFitbitFactory.isLoggedIn().then`

factory.isLoggedIn = function() {
  return $http.get('/api/v1/fitbit/auth');
}

Upvotes: 1

Related Questions