CODEWITHSUNDEEP
pythonwebservertwisted
user498844
user498844

Reputation: 31

twisted web: how do I properly images from an images directory

I've successfully written a twisted web server that displays dynamically generated content. However, when I attempt to display image (png) files from a directory (~cwd/plots/image.png), the server fails without error and the browser either displays the alt text or the broken image icon. What am I doing wrong?

import sys
from twisted.internet import reactor
import twisted.python.filepath
from twisted.web import server, resource, static

FILES = ["plot/10.53.174.1.png", "plot/10.53.174.2.png", "plot/10.53.174.3.png"]

class Child(resource.Resource):

    def __init__(self,link, filename):
        resource.Resource.__init__(self)
        self.filename = filename
        self.link = link
        pass

    def render(self, request ):

        filepath = "/%s" % (self.filename)
        linkpath = "%s%s" % (self.link, filepath)

        self.getChild(linkpath, static.File(self.filename))


        return """ 
        <html><body> <head> <title>%s</title> </head> <body> <h1>%s</h1><br> <img src="%s" alt = "angry beaver" /> </body>""" % (self.link, self.link, linkpath)

class Toplevel(resource.Resource):
    #addSlash = True

    def render(self, request):


        request.write("""<html><body> <head> <title>monitor server listing</title> </head> <body> <h1>Server List</h1> <ul>""" )


        #assume a pre-validated list of  plot file names.  validate their presence anyway
        if FILES:
            for fileName in FILES:
                if os.path.exists(fileName):
                    try:

                        link =  fileName.split('.png')[0]
                        link =  link.split('plot')[1]
                        path = link[1:]

                        request.write('<li> <a href="%s">%s</a><br>' % (link, link))


                        root.putChild(path, Child(link, fileName))
                        #root.putChild(path, Child(fileName))


                    except Exception as why:
                        request.write("%s <br>" % (str(why)))
                else:
                    request.write(" you may think %s exists but it doesn't " % (fileName))

        else:
            request.write("""No files given""")

        request.write("""</ul></body></html>""")

        return ""






if __name__ == "__main__":

    root = resource.Resource()
    home = Toplevel()

    png_file = twisted.python.filepath.FilePath('./plot/')

    root.putChild('', home)

    site = server.Site(root)
    reactor.listenTCP(8007, site)
    reactor.run()

Upvotes: 3

Views: 2717

Answers (1)

Anatoly Orlov
Anatoly Orlov

Reputation: 406

  • First: View Source at http://localhost:8007/10.53.174.1, you must change code to render correct link to image.
  • Second: Use twisted.web.static.File to serve static content

Corrected code:

import sys
import os
from twisted.internet import reactor
import twisted.python.filepath
from twisted.web.static import File
from twisted.web import server, resource, static

FILES = ["plot/10.53.174.1.png", "plot/10.53.174.2.png", "plot/10.53.174.3.png"]

class Child(resource.Resource):

    def __init__(self,link, filename):
        resource.Resource.__init__(self)
        self.filename = filename
        self.link = link
        pass

    def render(self, request ):

        filepath = "/%s" % (self.filename)
        linkpath = filepath
        #linkpath = "%s%s" % (self.link, filepath)

        self.getChild(linkpath, static.File(self.filename))


        return """ 
        <html><body> <head> <title>%s</title> </head> <body> <h1>%s</h1><br> <img src="%s" alt = "angry beaver" /> </body>""" % (self.link, self.link, linkpath)

class Toplevel(resource.Resource):
    #addSlash = True

    def render(self, request):


        request.write("""<html><body> <head> <title>monitor server listing</title> </head> <body> <h1>Server List</h1> <ul>""" )


        #assume a pre-validated list of  plot file names.  validate their presence anyway
        if FILES:
            for fileName in FILES:
        request.write(fileName)
                if os.path.exists(fileName):
                    try:

                        link =  fileName.split('.png')[0]
                        link =  link.split('plot')[1]
                        path = link[1:]

                        request.write('<li> <a href="%s">%s</a><br>' % (link, link))


                        root.putChild(path, Child(link, fileName))
                        #root.putChild(path, Child(fileName))


                    except Exception as why:
                        request.write("%s <br>" % (str(why)))
                else:
                    request.write(" you may think %s exists but it doesn't " % (fileName))

        else:
            request.write("""No files given""")

        request.write("""</ul></body></html>""")

        return ""






if __name__ == "__main__":

    root = resource.Resource()
    home = Toplevel()

    png_file = twisted.python.filepath.FilePath('./plot/')

    plot_resource = File('./plot')

    root.putChild('', home)
    root.putChild('plot', plot_resource)

    site = server.Site(root)
    reactor.listenTCP(8007, site)
    reactor.run()

PS. You code is little ugly. You can improve it. Try to read this:

Upvotes: 1

Related Questions