CODEWITHSUNDEEP
sql-serverfunctionconvention
Booyeoo
Booyeoo

Reputation: 583

Best way of creating dynamic conditions in sql functions

I have a challenge regarding some "too much code produced" or not most elegant coding way issue:

ALTER FUNCTION [dbo].fn_Function
    (@Location NVARCHAR(30) ='ALL')
RETURNS @ReportTable TABLE(DateOfProviValidity date,
                           DateOfFixumValidity date,
                           UserID NVARCHAR(50)
                          )
AS
BEGIN
    DECLARE @CurrentMonth DATE

    SET @CurrentMonth = dbo.fn_getFirstOfMonth(getdate())

    IF @Location IS NOT NULL AND @Location <> 'ALL'
        INSERT INTO @ReportTable
            SELECT * 
            FROM dbo.fn_getFinalPData(@CurrentMonth) 
            WHERE 1 AND Location = @Location
    ELSE
        INSERT INTO @ReportTable
            SELECT * 
            FROM dbo.fn_getFinalPData(@CurrentMonth) 
            WHERE 1 AND Location IS NOT NULL

    RETURN
END

Is there a possibility to get rid of the initial IF @Location statement and add it more closely to the Where clause?

My issue is that the case statement doesn't work as I can't do a Location equals or IS NOT NULL statement.

Upvotes: 0

Views: 44

Answers (2)

Abdul Rasheed
Abdul Rasheed

Reputation: 6729

Try this one,

SELECT * 
FROM dbo.fn_getFinalPData(@CurrentMonth) 
WHERE   1 
    AND Location    =   ISNULL(NULLIF(@Location,'ALL'),Location)

Upvotes: 0

Zohar Peled
Zohar Peled

Reputation: 82474

What about something like this?

INSERT INTO @ReportTable
SELECT * 
FROM dbo.fn_getFinalPData(@CurrentMonth) 
WHERE ISNULL(@Location, 'ALL') <> 'ALL'
OR Location = @Location

Upvotes: 1

Related Questions